Buffer: Fix that compress setting causes unexpected error when receiving already compressed MessagePack
#4147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting `compress gzip` of buffer, and it tries to process
CompressedMessagePackEventStream, the following error occurs.
[error]: xxx unexpected error on reading data
host="xxx" port=xxx error_class=ArgumentError
error="unknown keyword: :packer"
This is caused by the signature unmatch in
c6c6c03.
A possible use case is a two-stage transfer.
Forwarder1(out_forward) -> Forwarder2(in_forward, out_forward) ->
Aggregator(in_forward)
In this case, Forwarder2 should process the data of
`CompressedMessagePackEventStream` as is (i.e. without
decompressing) and re-transfer the data to Aggregator.
Signed-off-by: Daijiro Fukuda <[email protected]>
ashie
approved these changes
Apr 13, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
What this PR does / why we need it:
Fix that
compresssetting causes an unexpected error when receiving already compressed MessagePack.When setting
compress gzipof buffer, and it tries to processCompressedMessagePackEventStream, the following error occurs.This is caused by the signature unmatching in c6c6c03.
A possible use case is a two-stage transfer.
Forwarder1(out_forward) -> Forwarder2(in_forward, out_forward) -> Aggregator(in_forward)
In this case, Forwarder2 should process the data of
CompressedMessagePackEventStreamas is (i.e. without decompressing) and re-transfer the data to Aggregator.Docs Changes:
Not needed.
Release Note:
Same as the title.