Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_cat: specify the reading size to read in binary mode #4730

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

Watson1978
Copy link
Contributor

Which issue(s) this PR fixes:
Fixes #4729

What this PR does / why we need it:
The binary files may not be read properly.
This changes to read files in binary mode.

Docs Changes:

Release Note:

@Watson1978 Watson1978 requested a review from daipom December 8, 2024 04:48
@Watson1978 Watson1978 added the CI Test/CI issues label Dec 8, 2024
@daipom daipom added the backport to LTS We will backport this fix to the LTS branch label Dec 9, 2024
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@daipom daipom merged commit f85b503 into fluent:master Dec 9, 2024
15 of 16 checks passed
@Watson1978 Watson1978 deleted the fix-test_cat branch December 9, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to LTS We will backport this fix to the LTS branch CI Test/CI issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: test_cat_secondary_file fails with NoMethodError: undefined method first' for nil:NilClass` on Windows
2 participants