Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LED controls behavior #723

Merged
merged 4 commits into from
Jun 19, 2022
Merged

fix: LED controls behavior #723

merged 4 commits into from
Jun 19, 2022

Conversation

matmen
Copy link
Member

@matmen matmen commented Jun 17, 2022

Closes #641

@matmen
fix: LED controls behavior
dbeda03 
Signed-off-by: Mathis Mensing <[email protected]>
@matmen matmen added the GH - Bug Something isn't working label Jun 17, 2022
@matmen matmen added this to the 1.19 milestone Jun 17, 2022
@matmen matmen requested a review from pedrolamas June 17, 2022 22:15
pedrolamas
pedrolamas previously approved these changes Jun 19, 2022
View reviewed changes
Copy link
Member

@pedrolamas pedrolamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matmen I've approved this PR, but you might want to check this before merging: matmen#3

@pedrolamas
chore: adds typings for Led
88a8043 
Signed-off-by: Pedro Lamas <[email protected]>
@matmen
Copy link
Member Author

matmen commented Jun 19, 2022

Looks good, thanks

@matmen matmen requested a review from pedrolamas June 19, 2022 15:32
@matmen matmen merged commit 0cbf650 into fluidd-core:develop Jun 19, 2022
@matmen matmen deleted the fix/led-controls branch June 19, 2022 15:58
matmen added a commit to matmen/fluidd that referenced this pull request Jun 27, 2022
@matmen @pedrolamas
fix: LED controls behavior (fluidd-core#723)
f74d7d8 
Signed-off-by: Mathis Mensing <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Co-authored-by: Pedro Lamas <[email protected]>
@matmen matmen mentioned this pull request Jul 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrolamas pedrolamas pedrolamas approved these changes

Assignees
No one assigned
Labels
GH - Bug Something isn't working
Projects
None yet
Milestone
1.19
Development

Successfully merging this pull request may close these issues.

RGBW LED modal doesn't include white
2 participants
@matmen @pedrolamas