Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apple pay #1202

Merged
merged 2 commits into from
Apr 12, 2023
Merged

fix: apple pay #1202

merged 2 commits into from
Apr 12, 2023

Conversation

jamesblasco
Copy link
Member

@jamesblasco jamesblasco commented Apr 11, 2023

  • Fixes Apple Pay
  1. onShippingContactSelected, onShippingMethodSelected, onCouponCodeEntered and onOrderTracking are now optional.

  2. When using onShippingContactSelected, onShippingMethodSelected. It will be required to call Stripe.instance.updatePlatformSheet with the new data

  3. If you want to enable orderTracking implement a callback onOrderTracking that calls Stripe.instance.configurePlatformOrderTracking

  4. To enable couponCode use PlatformPayConfirmParams.applePay.supportsCouponCode and PlatformPayConfirmParams.applePay.couponCode

@jamesblasco jamesblasco requested a review from remonh87 April 11, 2023 12:20
return;
});
methodChannel?.setMethodCallHandler(callHandler);
_updateHandlers();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

class PlatformPayOrderDetails with _$PlatformPayOrderDetails {
@JsonSerializable(explicitToJson: true)
const factory PlatformPayOrderDetails.applePay({
/// eg: "com.myapp.order"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think we should also add some explanatory description in the docs to it. I will do this in the sync branch

@jamesblasco jamesblasco merged commit 9fbb7a4 into main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants