add web exports #1957
Merged
add web exports #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 12, 2024 13:10
cedvdb
commented
Oct 12, 2024
| ElementAppearanceLabels; | ||
|
|
||
| // TODO: should not use src of other package | ||
| export 'package:stripe_js/src/api/elements/payment_element_options.dart'; |
There was a problem hiding this comment.
There are some overlaps between stripe_js/api and platform_interface so this file is exported instead. It is not recommended to do this this way. I added a TODO if someone wants to organize this in the future, in the meantime organizing exports is way out of scope of this PR.
|
@remonh87 requesting review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1955 some classes used in PaymentElement constructor are not exported.