[Impeller] disable all Adrenos older than 630 #57069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Dec 9, 2024
| default: | ||
| return false; | ||
| AdrenoGPU adreno = adreno_gpu_.value(); | ||
| // See: |
There was a problem hiding this comment.
Should this comment block also link to flutter/flutter#159834 ?
There was a problem hiding this comment.
same error basically, no additional info.
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 9, 2024
…160000) flutter/engine@37a7a14...4d0e9ac 2024-12-09 [email protected] [Impeller] switch Pipeline to use raw ptr instead of shared ptr for recorded references. (flutter/engine#57015) 2024-12-09 [email protected] [Impeller] disable all Adrenos older than 630 (flutter/engine#57069) 2024-12-09 [email protected] Roll Skia to 14f8f6d984ff (flutter/engine#57068) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jonahwilliams
added a commit
to jonahwilliams/engine
that referenced
this pull request
Dec 10, 2024
Fixes flutter/flutter#159834 Disable all older Adreno GPUs
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Fixes flutter#159834 Disable all older Adreno GPUs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#159834
Disable all older Adreno GPUs