Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[animations] add routeSettings and imageFilter options to showModal #279

Merged
merged 4 commits into from
Feb 23, 2021

Conversation

britannio
Copy link
Contributor

@britannio britannio commented Feb 6, 2021

Closes flutter/flutter#75568

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@@ -1,6 +1,6 @@
name: animations
description: Fancy pre-built animations that can easily be integrated into any Flutter application.
version: 2.0.0-nullsafety.0
version: 2.1.0-nullsafety.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 2.0.0 is still in pre-release, I don't think we need to bump the MINOR version for this. It can just be part of the final 2.0.0 release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I changed the version to 2.0.0-nullsafety.1

Copy link

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit. Thanks for the PR!

packages/animations/test/modal_test.dart Show resolved Hide resolved
@shihaohong shihaohong merged commit 41eb920 into flutter:master Feb 23, 2021
austinstoker pushed a commit to austinstoker/packages that referenced this pull request Apr 29, 2022
        by changing a bit the implementation of BeamerBackButtonDispatcher and adding
        BeamerChildBackButtonDispatcher that can be automatically created in nested Beamers.
        Dispatcher now also has an optional onBack closure for custom back button handling.

        This also makes BeamerDelegate.active public so it can be used in those edge cases where it's needed.

        - closes flutter#279
	- closes flutter#295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[animations] add routeSettings and imageFilter to showModal
3 participants