[cross_file] Move from flutter/plugins. #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le platforms. (flutter#3260) * Initial version of x_file package * Renamed from x_file to cross_file * Add back x_file type to file_selector * Fix formatting issues * Update homepage and version * Added README.md * Added missing copyright * Revert "Added missing copyright" This reverts commit cf7e8d5f3810ae646669f584738502a8cc3c5ca1. * Add missing copyright Co-Authored-By: Jason Panelli <[email protected]> * Renamed class implementation back to XFile * Fix formatting issues * Rename to cross_file * Added code owners for cross_file package Co-authored-by: Jason Panelli <[email protected]>
Update Flutter SDK constraint to match templates.
The next version of package:http expects URIs. See dart-lang/http#507
Also: skip some packages from the all_plugins app so CI passes.
Without this, the dummy ("interface") XFile implementation of these properties has different nullability than the others, and the analyzer doesn't match what the runtime actually sees.
|
This is a link with the changes after the package was moved to the new repo. |
|
Merged and published: https://pub.dev/packages/cross_file/versions/0.3.1+1 |
|
Don't forget to update your table in the README 😄 |
@kevmoo wow, I totally missed that one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cross_filedoesn't fit very well with the testing infra of flutter/plugins, since it's just a cross-platform abstraction of dart:io File, and not a proper plugin.It seems that flutter/packages might be a better home for this package, and it should have been always deployed here, but since it was forked off of a plugin, it lived until now in flutter/plugins.
This PR moves the package to flutter/packages, and only minimally changes code to comply with the slightly different analysis rules of this repo.
Pre-launch Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy.CHANGELOG.mdto add a description of the change.///).If you need help, consider asking for advice on the
#hackers-newchannel on Discord.