[ci] Update repository for the release of Flutter 3.24 #7331

stuartmorgan · 2024-08-07T13:55:47Z

Updates the repo for 3.24 per https://github.com/flutter/flutter/blob/master/docs/ecosystem/release/Updating-Packages-repo-for-a-stable-release.md

Also fixes some packages to list 3.22 as their minimum version, which hadn't already been done only because we were not previously doing the N-1 test for 3.19 as intended, so didn't notice cases where a package claimed 3.19 support but required a 3.22+ dependency.

stuartmorgan · 2024-08-07T13:56:45Z

.ci.yaml

@@ -292,21 +292,21 @@ targets:
    timeout: 30
    properties:
      target_file: analyze_legacy.yaml
-      channel: "3.22.0"
+      channel: "3.22.3"


This change looks wrong, but that's only because I apparently messed this up last time. It should have been 3.19.0 prior to this PR, which means we've been analyzing with N-2, but not actually with N-1, for the past stable cycle 😬

yjbanov · 2024-08-07T14:07:39Z

packages/url_launcher/url_launcher/CHANGELOG.md

@@ -1,3 +1,7 @@
+## NEXT
+
+* Updates minimum supported SDK version to Flutter 3.19/Dart 3.3.


@mdebbar @harryterkelsen Do we need to add something about the recent a11y fixes?

The a11y fixes are still in master, not in a stable release yet. Not sure what you had in mind here.

tarrinneal

Number go up!

yjbanov · 2024-08-07T14:12:11Z

I don't know enough about the release process for packages, but updating SDK constraints without bumping the package version feels wrong. Unless the latest package versions haven't been published yet, I guess.

stuartmorgan · 2024-08-07T14:20:51Z

updating SDK constraints without bumping the package version feels wrong

Could you elaborate on why? We do this every time, and it's our documented policy.

stuartmorgan · 2024-08-07T14:21:38Z

Version override: per repo policy

stuartmorgan · 2024-08-07T14:27:59Z

Looks like a bunch of web example apps had incorrectly-tight web constraints for their SDK constraint, which we didn't catch due to the N-1 testing mistake. I'm not sure if they can be relaxed, so I'm going to drop N-2 support for all of those packages.

yjbanov · 2024-08-07T16:32:14Z

Looks like a bunch of web example apps had incorrectly-tight web constraints for their SDK constraint, which we didn't catch due to the N-1 testing mistake. I'm not sure if they can be relaxed, so I'm going to drop N-2 support for all of those packages.

cc @kevmoo To confirm this is the right move.

yjbanov · 2024-08-07T16:35:24Z

updating SDK constraints without bumping the package version feels wrong

Could you elaborate on why? We do this every time, and it's our documented policy.

To be clear, I don't mean updating SDK constraints in git is wrong. I only mean it would be wrong to publish a package to pub.dev under the same version but with different constraints. The pub client could cache the package and believe that nothing's changed, because the version is the same, while there's different SDK constraints lurking in the ecosystem under the same package version.

stuartmorgan · 2024-08-07T16:52:33Z

cc @kevmoo To confirm this is the right move.

If someone really wants to re-add support for 3.19 in those packages, it can always be done in a follow-up PR.

I only mean it would be wrong to publish a package to pub.dev under the same version but with different constraints.

It would also be impossible, so I'm not following.

yjbanov · 2024-08-07T17:12:49Z

It would also be impossible

We're good then.

…er/packages#7331)

flutter/packages@551bde5...5cc0a01 2024-08-07 [email protected] [ci] Update repository for the release of Flutter 3.24 (flutter/packages#7331) 2024-08-07 [email protected] Roll Flutter (stable) from b0850be to 80c2e84 (1397 revisions) (flutter/packages#7322) 2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.5 to 4.3.6 (flutter/packages#7330) 2024-08-07 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.7 to 1.13.12 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7189) 2024-08-07 [email protected] [google_maps_flutter] Marker clustering support (flutter/packages#4319) 2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.15 to 3.26.0 (flutter/packages#7329) 2024-08-07 [email protected] Manual roll Flutter from 1dd7141 to 0a7f8af (23 revisions) (flutter/packages#7328) 2024-08-06 [email protected] [image_picker_ios] Update image picker UI test query for iOS 18 (flutter/packages#7325) 2024-08-06 [email protected] [google_maps_flutter] Add marker clustering support - iOS implementation (flutter/packages#6186) 2024-08-06 [email protected] [url_launcher] launchUrl always returns true for valid schemes on the web. (flutter/packages#7229) 2024-08-06 [email protected] [google_maps_flutter] Add heatmap support (flutter/packages#3257) 2024-08-06 [email protected] [local_auth] Endorse macOS (flutter/packages#7274) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

stuartmorgan added 6 commits August 7, 2024 09:46

Update version mapping

04b303f

Update N-1 and N-2 configs

219a4e8

Update min allowed version

d936d82

Update SDK lower bounds for new min-min

b977122

Changelogs

1203d08

Update release action

c8b420e

stuartmorgan requested review from cbracken, hellohuanlin, jmagman, tarrinneal, LouiseHsu, loic-sharma, gmackall, MitchellGoodwin, bparrishMines, yjbanov, jonahwilliams, Hixie, ditman, gspencergoog, christopherfujino, chunhtai, domesticmouse and goderbauer as code owners August 7, 2024 13:55

github-actions bot added p: cross_file p: extension_google_sign_in_as_googleapis_auth p: flutter_template_images p: metrics_center p: multicast_dns p: palette_generator labels Aug 7, 2024

github-actions bot added p: video_player p: url_launcher p: shared_preferences p: standard_message_codec labels Aug 7, 2024

stuartmorgan commented Aug 7, 2024

View reviewed changes

yjbanov reviewed Aug 7, 2024

View reviewed changes

tarrinneal approved these changes Aug 7, 2024

View reviewed changes

stuartmorgan changed the title ~~Stable update 3 24~~ [ci] Update repository for the release of Flutter 3.24 Aug 7, 2024

stuartmorgan added the override: no versioning needed Override the check requiring version bumps for most changes label Aug 7, 2024

Fix packages that incorrectly listed 3.19 support

1ee4a0e

github-actions bot added the platform-web label Aug 7, 2024

Merge branch 'main' into stable-update-3-24

b94bdf4

gspencergoog approved these changes Aug 7, 2024

View reviewed changes

yjbanov approved these changes Aug 7, 2024

View reviewed changes

stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2024

auto-submit bot merged commit 5cc0a01 into flutter:main Aug 7, 2024
77 checks passed

engine-flutter-autoroll mentioned this pull request Aug 7, 2024

Roll Packages from 551bde53f6ea to 5cc0a0160194 (12 revisions) flutter/flutter#153040

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 7, 2024

5cc0a01 [ci] Update repository for the release of Flutter 3.24 (flutt…

a0d422e

…er/packages#7331)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ci] Update repository for the release of Flutter 3.24 #7331

[ci] Update repository for the release of Flutter 3.24 #7331

stuartmorgan commented Aug 7, 2024 •

edited

Loading

stuartmorgan Aug 7, 2024

yjbanov Aug 7, 2024

mdebbar Aug 7, 2024

tarrinneal left a comment

yjbanov commented Aug 7, 2024

stuartmorgan commented Aug 7, 2024

stuartmorgan commented Aug 7, 2024

stuartmorgan commented Aug 7, 2024

yjbanov commented Aug 7, 2024

yjbanov commented Aug 7, 2024

stuartmorgan commented Aug 7, 2024

yjbanov commented Aug 7, 2024 •

edited

Loading

		@@ -1,3 +1,7 @@
		## NEXT

		* Updates minimum supported SDK version to Flutter 3.19/Dart 3.3.

[ci] Update repository for the release of Flutter 3.24 #7331

[ci] Update repository for the release of Flutter 3.24 #7331

Conversation

stuartmorgan commented Aug 7, 2024 • edited Loading

stuartmorgan Aug 7, 2024

Choose a reason for hiding this comment

yjbanov Aug 7, 2024

Choose a reason for hiding this comment

mdebbar Aug 7, 2024

Choose a reason for hiding this comment

tarrinneal left a comment

Choose a reason for hiding this comment

yjbanov commented Aug 7, 2024

stuartmorgan commented Aug 7, 2024

stuartmorgan commented Aug 7, 2024

stuartmorgan commented Aug 7, 2024

yjbanov commented Aug 7, 2024

yjbanov commented Aug 7, 2024

stuartmorgan commented Aug 7, 2024

yjbanov commented Aug 7, 2024 • edited Loading

stuartmorgan commented Aug 7, 2024 •

edited

Loading

yjbanov commented Aug 7, 2024 •

edited

Loading