Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[file_selector] Endorse the web implementation #3417

Closed
wants to merge 4 commits into from

Conversation

tugorez
Copy link
Contributor

@tugorez tugorez commented Jan 13, 2021

This PR endorses file_selector_web as file_selector's web implementation.

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@tugorez
Copy link
Contributor Author

tugorez commented Jan 13, 2021

cc @ditman

@google-cla google-cla bot added the cla: yes label Jan 13, 2021
@ditman ditman self-requested a review January 14, 2021 00:19
@ditman
Copy link
Member

ditman commented Jan 14, 2021

Before this gets merged, can you please update https://github.com/flutter/plugins/tree/master/packages/file_selector/file_selector_platform_interface so it depends in the latest version of cross_file?

@tugorez
Copy link
Contributor Author

tugorez commented Jan 14, 2021

Before this gets merged, can you please update https://github.com/flutter/plugins/tree/master/packages/file_selector/file_selector_platform_interface so it depends in the latest version of cross_file?

Sure, already sent #3422. After it is merged and released I'll make the ammendments and change this PR's status to ready for review. Thanks @ditman :)

@ditman
Copy link
Member

ditman commented Jan 15, 2021

I've just merged #3422, now waiting for CI to publish it.

@ditman
Copy link
Member

ditman commented Jan 15, 2021

The failing tests here were my fault, I never published 1.0.3 of the platform_interface. I've now published 1.0.3+1 and restarted the tests here. Everything should pass now.

@google-cla
Copy link

google-cla bot commented Jan 15, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jan 15, 2021
@ditman
Copy link
Member

ditman commented Jan 15, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Jan 15, 2021
@tugorez tugorez marked this pull request as ready for review January 15, 2021 19:36
@ditman
Copy link
Member

ditman commented Jan 16, 2021

This will need to be rebased again, it's missing a CI fix from master! Sorry for the inconvenience!

@tugorez
Copy link
Contributor Author

tugorez commented Jan 22, 2021

This PR is ready to go @ditman :)!

@tugorez
Copy link
Contributor Author

tugorez commented Mar 5, 2021

This was already endorsed https://github.com/flutter/plugins/blob/master/packages/file_selector/file_selector/pubspec.yaml. Marking this as closed

@tugorez tugorez closed this Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants