-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[file_selector] Endorse the web implementation #3417
Conversation
cc @ditman |
Before this gets merged, can you please update https://github.com/flutter/plugins/tree/master/packages/file_selector/file_selector_platform_interface so it depends in the latest version of |
Sure, already sent #3422. After it is merged and released I'll make the ammendments and change this PR's status to ready for review. Thanks @ditman :) |
I've just merged #3422, now waiting for CI to publish it. |
The failing tests here were my fault, I never published 1.0.3 of the platform_interface. I've now published 1.0.3+1 and restarted the tests here. Everything should pass now. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
15e7837
to
69a3138
Compare
This will need to be rebased again, it's missing a CI fix from master! Sorry for the inconvenience! |
77050af
to
14d53ac
Compare
14d53ac
to
75874ee
Compare
This PR is ready to go @ditman :)! |
This was already endorsed https://github.com/flutter/plugins/blob/master/packages/file_selector/file_selector/pubspec.yaml. Marking this as closed |
This PR endorses file_selector_web as file_selector's web implementation.
Pre-launch Checklist
[shared_preferences]
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.