Include copyright licenses in bundled distributions #432
Conversation
This comment has been minimized.
This comment has been minimized.
| return Array.from(new Set(deps.concat(deps.flatMap(dependency => ( | ||
| dependencies(require(`${dependency}/package.json`)) | ||
| ))))); |
There was a problem hiding this comment.
Should this array be sorted in some way?
There was a problem hiding this comment.
I don't see why. But I'm considering listing them out myself instead of generating them like this, in which case I can choose any order I'd like.
There was a problem hiding this comment.
I don't like to rely on the internal ordering of unordered data structures. Even if the ordering is deterministic, it may appear arbitrary. Additionally, the relative ordering of elements may change when an element is added to the set, which could result in noisy diffs.
I don't know whether these concerns apply in this particular situation.
There was a problem hiding this comment.
I don't think it matters for the licenses to be listed in arbitrary order.
|
@davidchambers How do you view this change at the conceptual level? |
|
I'm asking because the license conditions for JavaScript libraries are very commonly ignored without consequences. Just think of all the WebPack -created web apps that bundle thousands of packages with various open source licenses and distribute those bundles to thousands of computers without any kind of attribution. Such is the nature of the web. The lines also get fairly blurry fairly quickly. Imagine I don't bundle my dependencies, but host them as-is on my web server. This might become more common in the future as HTTP2 and ESM gain traction. The license file is neatly hosted as well, alongside the JavaScript. But a user agent only ever fetches the JavaScript file, because I'm just curious about your views and opinions on this matter. |
Very positively. You are doing what you can to respect the licences, which is laudable. :) |
| @@ -1,5 +1,5 @@ | |||
| The MIT License (MIT) | |||
| Copyright (c) 2018 Aldwin Vlasblom | |||
| Copyright (c) 2020 Aldwin Vlasblom | |||
There was a problem hiding this comment.
I see that this project does not yet use sanctuary-scripts. ;)
Fluture distributes several bundles which include its dependencies.
Each of these dependencies are licensed under the MIT license (thank you @davidchambers), so I am allowed to redistribute them.
There is one condition though, and that is that I include the copyright notice in these distributions, which I haven't (sorry @davidchambers).
This PR rectifies that.