Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: loadtester support kubectl type #1485

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

mumubin
Copy link

@mumubin mumubin commented Aug 22, 2023

Our project want to run a kubernetes job/pod for canary test.
But I didn't find a way to start a kubernetes job/pod except helm.
So this PR provide kubectl command

Fixes: #1478

Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @mumubin 🏅

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.24% ⚠️

Comparison is base (7fc007a) 54.56% compared to head (084daaf) 54.33%.

❗ Current head 084daaf differs from pull request most recent head f685a45. Consider uploading reports for the commit f685a45 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
- Coverage   54.56%   54.33%   -0.24%     
==========================================
  Files          84       85       +1     
  Lines       10143    10186      +43     
==========================================
  Hits         5535     5535              
- Misses       3953     3996      +43     
  Partials      655      655              
Files Changed Coverage Δ
pkg/loadtester/kubectl.go 0.00% <0.00%> (ø)
pkg/loadtester/server.go 12.07% <0.00%> (-0.88%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mumubin
Copy link
Author

mumubin commented Aug 23, 2023

LGTM! thanks @mumubin 🏅

Thanks for your review.
I see that the test coverage has dropped a bit, do these need to be paid attention to?
I want to imitate the command of helmv3 to supplement the test, but I can't find the helmv3 test code.

@aryan9600
Copy link
Member

I see that the test coverage has dropped a bit, do these need to be paid attention to?

no, its fine for now, thanks for your contribution :)

@aryan9600 aryan9600 merged commit 5a809d7 into fluxcd:main Aug 28, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is there a way to start a kubernetes job/pod at flagger-tester?
3 participants