Improve gotk reconcile helmrelease readiness check

[hiddeco]

As the helm-controller does not reset the Ready==True condition without a state change, the current readiness check for the command may result in a false positive.

To prevent this, the Status fields in the HelmRelease can be consulted to ensure reported state is from after the reconciliation request was made (via Status.LastObservedTime).

[seaneagan]

See also #217

I think the current check would still have a race condition even if the helm-controller reset the Ready condition on each reconciliation, since it doesn't check that the reconcilAt annotation has actually resulted in a new reconciliation.

[stefanprodan]

The race condition could be solved for all the toolkit objects if we check the ObservedGeneration. An annotation change will bump the generation, then from gotk we wait for ObservedGeneration to equal to Generation, then check the Ready condition.

[hiddeco]

I do not think that annotating a resource causes a generation bump for custom resources.

See the in-code comments in kubernetes-sigs/controller-runtime#553

[stefanprodan]

Ah I was looking at the Deployment kind but that's the exception.