-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the sprig functions library #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@souleb please add a section here https://github.com/fluxcd/image-automation-controller/blob/main/docs/spec/v1beta1/imageupdateautomations.md#commit-message-template-data about spring functions and provide an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neatly done, thank you @souleb. I've made a couple of suggestions; see what you think, and if you're happier leaving things as they are, respond with a comment.
Additionally: first PR high-five ✋ ! |
c28f4ea
to
3df2277
Compare
@stefanprodan anything I can do to move this forward? |
I think you have done all that's been asked of you 👍 You could rebase on |
All functions are not supported, The following are discarded: // Date functions "date", "date_in_zone", "date_modify", "now", "htmlDate", "htmlDateInZone", "dateInZone", "dateModify", // Strings "randAlphaNum", "randAlpha", "randAscii", "randNumeric", "uuidv4", // OS "env", "expandenv", // Network "getHostByName", Signed-off-by: Soule BA <[email protected]>
12ceb8f
to
bc3d7b2
Compare
thanks @squaremo. Done! |
This will make lots of users happy, thank you @souleb! |
Adresses #160
All functions are not supported, The following are discarded:
Commit message templating can use those functions
Signed-off-by: Soule BA [email protected]