This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Support gRPC health checking #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses flyteorg/flyte#489. For now only server level health checking is supported but we could extend to service level when needed later.
|
@kumare3 Would like to take a look at this as well? Thanks. |
chanadian
reviewed
Aug 28, 2020
|
|
||
| healthServer := health.NewServer() | ||
| healthServer.SetServingStatus("", grpc_health_v1.HealthCheckResponse_SERVING) | ||
| grpc_health_v1.RegisterHealthServer(grpcServer, healthServer) |
There was a problem hiding this comment.
👍 nice
nit: we can rename the http health check method below to serveHTTPHealthcheck, this is for integration into proxies like Envoy's health check
There was a problem hiding this comment.
PTAL again and help merge it. Thanks.
chanadian
previously approved these changes
Aug 28, 2020
chanadian
approved these changes
Aug 28, 2020
|
LGTM, Merging |
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Support gRPC health checking.
Type
Are all requirements met?
Complete description
The implementation of https://github.com/grpc/grpc/blob/master/doc/health-checking.md is part of go gRPC lib.
Tracking Issue
flyteorg/flyte#489
Follow-up issue
NA