Logger disable HTML escaping (#4828)

Signed-off-by: Andrew Dye <[email protected]>

flytestdlib/logger/logger.go

@@ -41,7 +41,8 @@ func onConfigUpdated(cfg Config) {
 	default:
 		if _, isJSON := logrus.StandardLogger().Formatter.(*logrus.JSONFormatter); !isJSON {
 			logrus.SetFormatter(&logrus.JSONFormatter{
-				DataKey: jsonDataKey,
+				DataKey:           jsonDataKey,
+				DisableHTMLEscape: true,
 				FieldMap: logrus.FieldMap{
 					logrus.FieldKeyTime: "ts",
 				},

flytestdlib/logger/logger_test.go

@@ -6,13 +6,19 @@ package logger
 import (
 	"context"
 	"reflect"
+	"strings"
 	"testing"
 
 	"github.com/sirupsen/logrus"
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func init() {
+	initLogger()
+}
+
+func initLogger() {
 	if err := SetConfig(&Config{
 		Level:             InfoLevel,
 		IncludeSourceCode: true,
@@ -585,4 +591,32 @@ func Test_onConfigUpdated(t *testing.T) {
 			onConfigUpdated(tt.args.cfg)
 		})
 	}
+	initLogger()
+}
+
+type loggerHook struct {
+	messages []string
+}
+
+func (h *loggerHook) Levels() []logrus.Level {
+	return logrus.AllLevels
+}
+
+func (h *loggerHook) Fire(entry *logrus.Entry) error {
+	s, err := entry.String()
+	if err != nil {
+		panic(err)
+	}
+	h.messages = append(h.messages, s)
+	return nil
+}
+
+func TestConfigFormatterJson_DontEscapeHTML(t *testing.T) {
+	ctx := context.TODO()
+	hook := &loggerHook{}
+	logrus.AddHook(hook)
+
+	Info(ctx, "foo&bar")
+	require.Len(t, hook.messages, 1)
+	assert.True(t, strings.Contains(hook.messages[0], "foo&bar"), hook.messages[0])
 }