Build flyte-binary image during sandbox-bundled build (#3216)

Signed-off-by: Jeev B <[email protected]> Signed-off-by: Jeev B <[email protected]>
flyteorg · Jan 7, 2023 · 0d9aa54 · 0d9aa54
1 parent 10285d9
commit 0d9aa54
Showing 1 changed file with 14 additions and 16 deletions.
diff --git a/docker/sandbox-bundled/Makefile b/docker/sandbox-bundled/Makefile
@@ -1,21 +1,19 @@
+define FLYTE_BINARY_BUILD
+mkdir -p images/tar/$(1)
+
+docker buildx build \
+	--build-arg FLYTECONSOLE_VERSION=$(FLYTECONSOLE_VERSION) \
+	--platform linux/$(1) \
+	--tag flyte-binary:sandbox \
+	--output type=docker,dest=images/tar/$(1)/flyte-binary.tar \
+	../..
+
+endef
+
 .PHONY: flyte
-flyte: FLYTE_BINARY_VERSION := latest
+flyte: FLYTECONSOLE_VERSION := latest
 flyte:
-	mkdir -p images/tar/amd64
-	docker pull --platform linux/amd64 \
-		ghcr.io/flyteorg/flyte-binary:$(FLYTE_BINARY_VERSION)
-	docker tag ghcr.io/flyteorg/flyte-binary:$(FLYTE_BINARY_VERSION) \
-		flyte-binary:sandbox
-	docker save --output  images/tar/amd64/flyte-binary.tar flyte-binary:sandbox
-	docker rmi flyte-binary:sandbox
-
-	mkdir -p images/tar/arm64
-	docker pull --platform linux/arm64 \
-		ghcr.io/flyteorg/flyte-binary:$(FLYTE_BINARY_VERSION)
-	docker tag ghcr.io/flyteorg/flyte-binary:$(FLYTE_BINARY_VERSION) \
-		flyte-binary:sandbox
-	docker save --output  images/tar/arm64/flyte-binary.tar flyte-binary:sandbox
-	docker rmi flyte-binary:sandbox
+	$(foreach arch,amd64 arm64,$(call FLYTE_BINARY_BUILD,$(arch)))
 
 .PHONY: manifests
 manifests: