Skip to content

Commit

Permalink
Revert forcing non-interruptibility on kfoperator masters
Browse files Browse the repository at this point in the history
Signed-off-by: Jeev B <[email protected]>
  • Loading branch information
jeevb committed Nov 30, 2023
1 parent 307bead commit 2116ec2
Showing 1 changed file with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -302,10 +302,6 @@ type allowsCommandOverride interface {

func ToReplicaSpecWithOverrides(ctx context.Context, taskCtx pluginsCore.TaskExecutionContext, rs kfDistributedReplicaSpec, primaryContainerName string, isMaster bool) (*commonOp.ReplicaSpec, error) {
taskCtxOptions := []flytek8s.PluginTaskExecutionContextOption{}
// Master should always run as non-interruptible
if isMaster {
taskCtxOptions = append(taskCtxOptions, flytek8s.WithInterruptible(false))
}
if rs != nil && rs.GetResources() != nil {
resources, err := flytek8s.ToK8sResourceRequirements(rs.GetResources())
if err != nil {
Expand Down

0 comments on commit 2116ec2

Please sign in to comment.