updated dead code to comment

Signed-off-by: Daniel Rammer <[email protected]>
flyteorg · Nov 6, 2023 · 4817d72 · 4817d72
1 parent d628c19
commit 4817d72
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/flyteplugins/go/tasks/plugins/array/core/state.go b/flyteplugins/go/tasks/plugins/array/core/state.go
@@ -273,7 +273,9 @@ func SummaryToPhase(ctx context.Context, minSuccesses int64, summary arraystatus
 		logger.Infof(ctx, "Array is still running and waiting for resources totalWaitingForResources[%v]", totalWaitingForResources)
 		return PhaseWaitingForResources
 	}
-	//if totalSuccesses >= minSuccesses && totalRunning == 0 && totalRetryableFailures == 0 {
+
+	// if we have enough successes, ensure all tasks are in a terminal phase (success or failure)
+	// before transitioning to the next phase.
 	if totalSuccesses >= minSuccesses && totalSuccesses+totalPermanentFailures == totalCount {
 		logger.Infof(ctx, "Array succeeded because totalSuccesses[%v] >= minSuccesses[%v]", totalSuccesses, minSuccesses)
 		return PhaseWriteToDiscovery