Fix: Check for git authentication when GITHUB_TOKEN exists (#463)

Signed-off-by: Jeongwon Song <[email protected]>
flyteorg · Feb 20, 2024 · 8362431 · 8362431
1 parent cff5a3d
commit 8362431
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/flytectl/pkg/github/githubutil.go b/flytectl/pkg/github/githubutil.go
@@ -231,7 +231,12 @@ func GetGHRepoService() GHRepoService {
 			gh = github.NewClient(oauth2.NewClient(context.Background(), oauth2.StaticTokenSource(
 				&oauth2.Token{AccessToken: os.Getenv("GITHUB_TOKEN")},
 			)))
-		} else {
+			if _, err := ListReleases(flyte, gh.Repositories); err != nil {
+				logger.Warnf(context.Background(), "Found GITHUB_TOKEN but failed to fetch releases. Using empty http.Client: %s.", err)
+				gh = nil
+			}
+		}
+		if gh == nil {
 			gh = github.NewClient(&http.Client{})
 		}
 		return gh.Repositories