Added workflow flag for get launchplan (#287)

* Added workflow flag for get launchplan Signed-off-by: Prafulla Mahindrakar <[email protected]> * Using filter for workflow flag Signed-off-by: Prafulla Mahindrakar <[email protected]>
flyteorg · Mar 7, 2022 · a94cbdd · a94cbdd
1 parent 9aaba3e
commit a94cbdd
Show file tree

Hide file tree

Showing 5 changed files with 83 additions and 443 deletions.
diff --git a/flytectl/cmd/config/subcommand/launchplan/config_flags.go b/flytectl/cmd/config/subcommand/launchplan/config_flags.go
diff --git a/flytectl/cmd/config/subcommand/launchplan/config_flags_test.go b/flytectl/cmd/config/subcommand/launchplan/config_flags_test.go
diff --git a/flytectl/cmd/config/subcommand/launchplan/launchplan_config.go b/flytectl/cmd/config/subcommand/launchplan/launchplan_config.go
@@ -17,4 +17,5 @@ type Config struct {
 	Version  string          `json:"version" pflag:",version of the launchplan to be fetched."`
 	Latest   bool            `json:"latest" pflag:", flag to indicate to fetch the latest version, version flag will be ignored in this case"`
 	Filter   filters.Filters `json:"filter" pflag:","`
+	Workflow string          `json:"workflow" pflag:",name of the workflow for which the launchplans need to be fetched."`
 }
diff --git a/flytectl/cmd/get/launch_plan.go b/flytectl/cmd/get/launch_plan.go
@@ -2,6 +2,7 @@ package get
 
 import (
 	"context"
+	"fmt"
 
 	"github.com/flyteorg/flytectl/cmd/config"
 	"github.com/flyteorg/flytectl/cmd/config/subcommand/launchplan"
@@ -40,6 +41,12 @@ Retrieve a particular version of the launch plan by name within the project and
 
  flytectl get launchplan -p flytesnacks -d development  core.basic.lp.go_greet --version v2
 
+Retrieve all launch plans for a given workflow name:
+
+::
+
+ flytectl get launchplan -p flytesnacks -d development --workflow core.flyte_basics.lp.go_greet
+
 Retrieve all the launch plans with filters:
 ::
 
@@ -170,6 +177,13 @@ func getLaunchPlanFunc(ctx context.Context, args []string, cmdCtx cmdCore.Comman
 		return nil
 	}
 
+	if len(launchplan.DefaultConfig.Workflow) > 0 {
+		if len(launchplan.DefaultConfig.Filter.FieldSelector) > 0 {
+			return fmt.Errorf("fieldSelector cannot be specified with workflow flag")
+		}
+		launchplan.DefaultConfig.Filter.FieldSelector = fmt.Sprintf("workflow.name=%s", launchplan.DefaultConfig.Workflow)
+	}
+
 	launchPlans, err := cmdCtx.AdminFetcherExt().FetchAllVerOfLP(ctx, "", config.GetConfig().Project, config.GetConfig().Domain, launchplan.DefaultConfig.Filter)
 	if err != nil {
 		return err