revert

Signed-off-by: Future-Outlier <[email protected]>
flyteorg · Apr 10, 2024 · bbb2adb · bbb2adb
1 parent 83dece4
commit bbb2adb
Show file tree

Hide file tree

Showing 13 changed files with 20 additions and 78 deletions.
diff --git a/docker/sandbox-bundled/manifests/complete-agent.yaml b/docker/sandbox-bundled/manifests/complete-agent.yaml
@@ -816,7 +816,7 @@ type: Opaque
 ---
 apiVersion: v1
 data:
-  haSharedSecret: eExLb0xRRmZncXZFMUliTg==
+  haSharedSecret: WEJxZGNCTWJiNFUwZEd1bQ==
   proxyPassword: ""
   proxyUsername: ""
 kind: Secret
@@ -1412,7 +1412,7 @@ spec:
     metadata:
       annotations:
         checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
-        checksum/secret: 537ad3ed9da6f8f2a87806677cbd71695d7f90b19854034e812e9cbeea80ecb9
+        checksum/secret: 45571013e2bcbc17744162363ccc7fc5c99072b2553a3fe29f41660a07e2e864
       labels:
         app: docker-registry
         release: flyte-sandbox

diff --git a/docker/sandbox-bundled/manifests/complete.yaml b/docker/sandbox-bundled/manifests/complete.yaml
@@ -796,7 +796,7 @@ type: Opaque
 ---
 apiVersion: v1
 data:
-  haSharedSecret: eTBZd0U5ZkxKVEVpR2pVaA==
+  haSharedSecret: a1Zqcm1HUlcxZUN4SExqSw==
   proxyPassword: ""
   proxyUsername: ""
 kind: Secret
@@ -1360,7 +1360,7 @@ spec:
     metadata:
       annotations:
         checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
-        checksum/secret: 84577f342244aca559dc268d756fbe3900d326ab95c5f1c563dbf183716e3873
+        checksum/secret: bf4abdac7aaf5a74cf2f12f7511d4af46e5c2b8228637c5eb29f9ed5399e4942
       labels:
         app: docker-registry
         release: flyte-sandbox

diff --git a/docker/sandbox-bundled/manifests/dev.yaml b/docker/sandbox-bundled/manifests/dev.yaml
@@ -499,7 +499,7 @@ metadata:
 ---
 apiVersion: v1
 data:
-  haSharedSecret: eDE1MWRGRGRFTGJRQjZhYQ==
+  haSharedSecret: dkdTTTV4ZkNpc2pneXZBRQ==
   proxyPassword: ""
   proxyUsername: ""
 kind: Secret
@@ -934,7 +934,7 @@ spec:
     metadata:
       annotations:
         checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
-        checksum/secret: 9e1f60c351c7c8328dce538c41022037eba9df019b10a19cf53dad8e851042be
+        checksum/secret: 40299f1a8b9fffd1ef10051c289e1d654de7f755fff5f44cde65a9cf96bcd543
       labels:
         app: docker-registry
         release: flyte-sandbox

diff --git a/docs/deployment/agents/airflow.rst b/docs/deployment/agents/airflow.rst
@@ -67,14 +67,6 @@ Specify agent configuration
               agent-service:
                 supportedTaskTypes:
                 - airflow
-                defaultAgent:
-                  defaultTimeout: 10s
-                  endpoint: dns:///flyteagent.flyte.svc.cluster.local:8000
-                  insecure: true
-                  timeouts:
-                    CreateTask: 10s
-                    GetTask: 10s
-                    DeleteTask: 10s
 
 
 Upgrade the Flyte Helm release

diff --git a/docs/deployment/agents/bigquery.rst b/docs/deployment/agents/bigquery.rst
@@ -75,14 +75,6 @@ Specify agent configuration
               agent-service:
                 supportedTaskTypes:
                 - bigquery_query_job_task
-                defaultAgent:
-                  defaultTimeout: 10s
-                  endpoint: dns:///flyteagent.flyte.svc.cluster.local:8000
-                  insecure: true
-                  timeouts:
-                    CreateTask: 10s
-                    GetTask: 10s
-                    DeleteTask: 10s
 
 Ensure that the propeller has the correct service account for BigQuery.
 

diff --git a/docs/deployment/agents/chatgpt.rst b/docs/deployment/agents/chatgpt.rst
@@ -67,13 +67,8 @@ Specify agent configuration
                 supportedTaskTypes:
                 - chatgpt
                 defaultAgent:
-                  defaultTimeout: 10s
-                  endpoint: dns:///flyteagent.flyte.svc.cluster.local:8000
-                  insecure: true
                   timeouts:
-                    CreateTask: 10s
-                    GetTask: 10s
-                    DeleteTask: 10s
+                    ExecuteTaskSync: 10s
 
 Add the OpenAI API token
 -------------------------------

diff --git a/docs/deployment/agents/databricks.rst b/docs/deployment/agents/databricks.rst
@@ -205,14 +205,6 @@ Specify agent configuration
             agent-service:
               supportedTaskTypes:
               - spark
-              defaultAgent:
-                defaultTimeout: 10s
-                endpoint: dns:///flyteagent.flyte.svc.cluster.local:8000
-                insecure: true
-                timeouts:
-                  CreateTask: 10s
-                  GetTask: 10s
-                  DeleteTask: 10s
 
 Add the Databricks access token
 -------------------------------

diff --git a/docs/deployment/agents/mmcloud.rst b/docs/deployment/agents/mmcloud.rst
@@ -75,14 +75,6 @@ Enable the MMCloud agent by adding the following config to the relevant YAML fil
       - mmcloud_task
       agentForTaskTypes:
       - mmcloud_task: mmcloud-agent
-      defaultAgent:
-        defaultTimeout: 10s
-        endpoint: dns:///flyteagent.flyte.svc.cluster.local:8000
-        insecure: true
-        timeouts:
-          CreateTask: 10s
-          GetTask: 10s
-          DeleteTask: 10s
 
 Substitute ``<AGENT_ENDPOINT>`` with the endpoint of your MMCloud agent.
 

diff --git a/docs/deployment/agents/sagemaker_inference.rst b/docs/deployment/agents/sagemaker_inference.rst
@@ -66,14 +66,6 @@ Specify agent configuration
                 supportedTaskTypes:
                 - boto
                 - sagemaker-endpoint
-                defaultAgent:
-                  defaultTimeout: 10s
-                  endpoint: dns:///flyteagent.flyte.svc.cluster.local:8000
-                  insecure: true
-                  timeouts:
-                    CreateTask: 10s
-                    GetTask: 10s
-                    DeleteTask: 10s
 
 AWS credentials
 ---------------

diff --git a/docs/deployment/agents/sensor.rst b/docs/deployment/agents/sensor.rst
@@ -102,14 +102,6 @@ Enable the sensor agent by adding the following config to the relevant YAML file
               agent-service:
                 supportedTaskTypes:
                 - sensor
-                defaultAgent:
-                  defaultTimeout: 10s
-                  endpoint: dns:///flyteagent.flyte.svc.cluster.local:8000
-                  insecure: true
-                  timeouts:
-                    CreateTask: 10s
-                    GetTask: 10s
-                    DeleteTask: 10s
 
 
 Upgrade the deployment

diff --git a/docs/deployment/agents/snowflake.rst b/docs/deployment/agents/snowflake.rst
@@ -44,14 +44,6 @@ Specify agent configuration
           agent-service:
             supportedTaskTypes:
             - snowflake
-            defaultAgent:
-              defaultTimeout: 10s
-              endpoint: dns:///flyteagent.flyte.svc.cluster.local:8000
-              insecure: true
-              timeouts:
-                CreateTask: 10s
-                GetTask: 10s
-                DeleteTask: 10s
 
     .. group-tab:: Flyte core
 

diff --git a/docs/flyte_agents/developing_agents.md b/docs/flyte_agents/developing_agents.md
@@ -184,10 +184,7 @@ kubectl set image deployment/flyteagent flyteagent=ghcr.io/flyteorg/flyteagent:l
 kubectl rollout restart deployment flytepropeller -n flyte
 ```
 
-### 5. 
-
-
-### Canary deployment
+### 5. Canary deployment
 
 Agents can be deployed independently in separate environments. Decoupling agents from the
 production environment ensures that if any specific agent encounters an error or issue, it will not impact the overall production system.
@@ -202,15 +199,20 @@ you can route particular task requests to designated agent services by adjusting
  plugins:
    agent-service:
      supportedTaskTypes:
-       - bigquery_query_job_task
+       - sensor
        - default_task
        - custom_task
      # By default, all requests will be sent to the default agent.
      defaultAgent:
        endpoint: "dns:///flyteagent.flyte.svc.cluster.local:8000"
        insecure: true
        timeouts:
-         GetTask: 10s
+         # CreateTask, GetTask and DeleteTask are for async agents.
+         # ExecuteTaskSync is for sync agents.
+         CreateTask: 5s
+         GetTask: 5s
+         DeleteTask: 5s
+         ExecuteTaskSync: 10s
        defaultTimeout: 10s
      agents:
        custom_agent:

diff --git a/docs/flyte_agents/testing_agents_in_a_local_development_cluster.md b/docs/flyte_agents/testing_agents_in_a_local_development_cluster.md
@@ -57,7 +57,7 @@ tasks:
       - sidecar
       - K8S-ARRAY
     default-for-task-types:
-      - bigquery_query_job_task: agent-service
+      - sensor: agent-service
       - container: container
       - container_array: K8S-ARRAY
 ```
@@ -69,9 +69,10 @@ plugins:
       endpoint: "localhost:8000" # your grpc agent server port
       insecure: true
       timeouts:
-        CreateTask: 10s
-        GetTask: 10s
-        DeleteTask: 10s
+        CreateTask: 5s
+        GetTask: 5s
+        DeleteTask: 5s
+        ExecuteTaskSync: 10s
       defaultTimeout: 10s
 ```