Change volumes and volume mounts to list (#1497)

Signed-off-by: Yee Hing Tong <[email protected]>
flyteorg · Sep 20, 2021 · e903fe7 · e903fe7
1 parent 5886ad5
commit e903fe7
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 8 deletions.
diff --git a/CHANGELOG/CHANGELOG-v0.17.3-b2.md b/CHANGELOG/CHANGELOG-v0.17.3-b2.md
@@ -0,0 +1,3 @@
+# Flyte v0.17.3-b2
+
+Change additional Admin volumes and volume mounts to list
diff --git a/charts/flyte-core/README.md b/charts/flyte-core/README.md
@@ -106,8 +106,8 @@ helm install gateway bitnami/contour -n flyte
 | datacatalog.serviceAccount.imagePullSecrets | object | `{}` | ImapgePullSecrets to automatically assign to the service account |
 | datacatalog.tolerations | list | `[]` | tolerations for Datacatalog deployment |
 | db.database.host | string | `"postgres"` |  username: postgres |
-| flyteadmin.additionalVolumeMounts | object | `{}` |  |
-| flyteadmin.additionalVolumes | object | `{}` |  |
+| flyteadmin.additionalVolumeMounts | list | `[]` |  |
+| flyteadmin.additionalVolumes | list | `[]` |  |
 | flyteadmin.affinity | object | `{}` | affinity for Flyteadmin deployment |
 | flyteadmin.configPath | string | `"/etc/flyte/config/*.yaml"` | Default regex string for searching configuration files |
 | flyteadmin.image.pullPolicy | string | `"IfNotPresent"` |  |

diff --git a/charts/flyte-core/values.yaml b/charts/flyte-core/values.yaml
@@ -58,8 +58,8 @@ flyteadmin:
   # -- affinity for Flyteadmin deployment
   affinity: {}
   secrets: {}
-  additionalVolumes: {}
-  additionalVolumeMounts: {}
+  additionalVolumes: []
+  additionalVolumeMounts: []
 
 #
 # DATACATALOG SETTINGS

diff --git a/charts/flyte/README.md b/charts/flyte/README.md
@@ -131,8 +131,8 @@ helm install gateway bitnami/contour -n flyte
 | datacatalog.serviceAccount.imagePullSecrets | object | `{}` | ImapgePullSecrets to automatically assign to the service account |
 | datacatalog.tolerations | list | `[]` | tolerations for Datacatalog deployment |
 | db.database.host | string | `"postgres"` |  username: postgres |
-| flyteadmin.additionalVolumeMounts | object | `{}` |  |
-| flyteadmin.additionalVolumes | object | `{}` |  |
+| flyteadmin.additionalVolumeMounts | list | `[]` |  |
+| flyteadmin.additionalVolumes | list | `[]` |  |
 | flyteadmin.affinity | object | `{}` | affinity for Flyteadmin deployment |
 | flyteadmin.configPath | string | `"/etc/flyte/config/*.yaml"` | Default regex string for searching configuration files |
 | flyteadmin.image.pullPolicy | string | `"IfNotPresent"` | Docker image pull policy |

diff --git a/charts/flyte/values.yaml b/charts/flyte/values.yaml
@@ -59,8 +59,8 @@ flyteadmin:
   # -- affinity for Flyteadmin deployment
   affinity: {}
   secrets: {}
-  additionalVolumes: {}
-  additionalVolumeMounts: {}
+  additionalVolumes: []
+  additionalVolumeMounts: []
 
 #
 # DATACATALOG SETTINGS
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		# Flyte v0.17.3-b2

		Change additional Admin volumes and volume mounts to list