Fix flaky auto_refresh_test (#5438)

Signed-off-by: Kevin Su <[email protected]>
flyteorg · Jun 4, 2024 · fceb78f · fceb78f
1 parent 5a81e76
commit fceb78f
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/flytestdlib/cache/auto_refresh_test.go b/flytestdlib/cache/auto_refresh_test.go
@@ -84,13 +84,13 @@ func TestCacheFour(t *testing.T) {
 			assert.NoError(t, err)
 		}
 
-		// Wait half a second for all resync periods to complete
-		time.Sleep(500 * time.Millisecond)
-		for i := 1; i <= 10; i++ {
-			item, err := cache.Get(fmt.Sprintf("%d", i))
-			assert.NoError(t, err)
-			assert.Equal(t, 10, item.(fakeCacheItem).val)
-		}
+		assert.EventuallyWithT(t, func(c *assert.CollectT) {
+			for i := 1; i <= 10; i++ {
+				item, err := cache.Get(fmt.Sprintf("%d", i))
+				assert.NoError(c, err)
+				assert.Equal(c, 10, item.(fakeCacheItem).val)
+			}
+		}, 3*time.Second, 100*time.Millisecond)
 		cancel()
 	})