Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flyteorg/flyte
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.4.0-b0
Choose a base ref
...
head repository: flyteorg/flyte
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref

Commits on Apr 9, 2019

  1. Initial Release

    EngHabu committed Apr 9, 2019
    Copy the full SHA
    0886e68 View commit details
  2. Update ReadMe Title

    EngHabu committed Apr 9, 2019
    Copy the full SHA
    ab8b667 View commit details
  3. Update Travis GoVersion

    EngHabu committed Apr 9, 2019
    Copy the full SHA
    b4462cc View commit details
  4. Copy the full SHA
    660c51c View commit details
  5. Copy the full SHA
    24e2164 View commit details
  6. Merge pull request #1 from lyft/readme-update

    Update README Title
    EngHabu authored Apr 9, 2019
    Copy the full SHA
    9139df8 View commit details
  7. Add CODEOWNERS file

    EngHabu committed Apr 9, 2019
    Copy the full SHA
    60a7971 View commit details

Commits on Apr 10, 2019

  1. Remove comments

    EngHabu committed Apr 10, 2019
    Copy the full SHA
    1d47c19 View commit details
  2. regenerate

    EngHabu committed Apr 10, 2019
    Copy the full SHA
    8b92db6 View commit details
  3. Copy the full SHA
    17757da View commit details

Commits on Apr 11, 2019

  1. Merge pull request #2 from lyft/codeowners

    Add CODEOWNERS file
    EngHabu authored Apr 11, 2019
    Copy the full SHA
    de926e4 View commit details
  2. Copy the full SHA
    778ac0a View commit details

Commits on Apr 17, 2019

  1. Copy the full SHA
    13aff7a View commit details
  2. atomic symlink

    EngHabu committed Apr 17, 2019
    Copy the full SHA
    6cfceec View commit details

Commits on Apr 18, 2019

  1. simplify tests

    EngHabu committed Apr 18, 2019
    Copy the full SHA
    6cc4a4d View commit details
  2. Add marshal utils

    EngHabu committed Apr 18, 2019
    Copy the full SHA
    a7ce2b5 View commit details
  3. lint

    EngHabu committed Apr 18, 2019
    Copy the full SHA
    362c166 View commit details
  4. lint

    EngHabu committed Apr 18, 2019
    Copy the full SHA
    904eeff View commit details
  5. docs & refactor

    EngHabu committed Apr 18, 2019
    Copy the full SHA
    97117a8 View commit details
  6. minor

    EngHabu committed Apr 18, 2019
    Copy the full SHA
    c444a2c View commit details
  7. lint

    EngHabu committed Apr 18, 2019
    Copy the full SHA
    74d5915 View commit details
  8. solidify unit tests

    EngHabu committed Apr 18, 2019
    Copy the full SHA
    578749a View commit details
  9. Refactor test

    EngHabu committed Apr 18, 2019
    Copy the full SHA
    7e82abf View commit details
  10. lint

    EngHabu committed Apr 18, 2019
    Copy the full SHA
    5ec3859 View commit details
  11. Merge pull request #6 from lyft/config-default-values

    Add option to PFlags to use a variable to get default values
    EngHabu authored Apr 18, 2019
    Copy the full SHA
    d5ebc3a View commit details

Commits on Apr 22, 2019

  1. adding lru Cache

    Yee Hing Tong committed Apr 22, 2019
    Copy the full SHA
    29a2c51 View commit details
  2. add a state for unchanged

    Yee Hing Tong committed Apr 22, 2019
    Copy the full SHA
    a54187b View commit details

Commits on Apr 23, 2019

  1. adding basic unit test

    Yee Hing Tong committed Apr 23, 2019
    Copy the full SHA
    6b9a891 View commit details
  2. go imports

    Yee Hing Tong committed Apr 23, 2019
    Copy the full SHA
    e9d5819 View commit details
  3. linting is complaining that i'm copying a mutex even though i copy it…

    … before using it
    Yee Hing Tong committed Apr 23, 2019
    Copy the full SHA
    3cb2359 View commit details
  4. Update utils/auto_refresh_cache.go

    Co-Authored-By: wild-endeavor <wild-endeavor@users.noreply.github.com>
    EngHabu and wild-endeavor authored Apr 23, 2019
    Copy the full SHA
    7987dc5 View commit details
  5. Update utils/auto_refresh_cache.go

    Co-Authored-By: wild-endeavor <wild-endeavor@users.noreply.github.com>
    EngHabu and wild-endeavor authored Apr 23, 2019
    Copy the full SHA
    7f46ee0 View commit details
  6. Update utils/auto_refresh_cache.go

    Co-Authored-By: wild-endeavor <wild-endeavor@users.noreply.github.com>
    EngHabu and wild-endeavor authored Apr 23, 2019
    Copy the full SHA
    0a2e1aa View commit details
  7. Merge pull request #9 from lyft/auto-refresh-lru

    Use an LRU in AutoRefreshCache
    wild-endeavor authored Apr 23, 2019
    Copy the full SHA
    3806fba View commit details
  8. Add free badges for the project (#4)

    - Badges for release, build passing, license and docs
     - TODO add badge for coverage
    Ketan Umare authored Apr 23, 2019
    Copy the full SHA
    6df902f View commit details
  9. Updated Version Handler to support BuildTime (#7)

    * Updated Version Handler to support BuildTime
    
     - Also added some documentation
     - Version information is outputted as JSON
    
    * lint fix
    Ketan Umare authored Apr 23, 2019
    Copy the full SHA
    556fa6c View commit details

Commits on Apr 24, 2019

  1. [pflags] If there is a default value, use it for tests. (#8)

    * If there is a default value, use it for tests.
    
    * fixes
    
    * regenerate
    EngHabu authored Apr 24, 2019
    Copy the full SHA
    1f05d0c View commit details
  2. Fix release tag image

    EngHabu authored Apr 24, 2019
    Copy the full SHA
    23a3d52 View commit details
  3. Copy the full SHA
    23d5f1d View commit details
  4. Copy the full SHA
    9de816c View commit details
  5. Hookkup Goreleaser (#10)

    * Goreleaser
    
    * Add contributing section
    
    * Update README.md
    
    * Add encrypted github token
    
    * Add version info to binary
    
    * update archive to archives
    
    * Update unit tests & docs
    
    * Update README.md
    
    * lint
    
    * lint again
    EngHabu authored Apr 24, 2019
    Copy the full SHA
    fa1cfb1 View commit details
  6. Copy the full SHA
    9f91550 View commit details
  7. Add godownloader script (#11)

    * Add godownloader script
    
    * Update README.md
    
    * typo
    EngHabu authored Apr 24, 2019
    Copy the full SHA
    555f18f View commit details
  8. Adding codecov to report unit test coverage (#13)

    Setup new makefile target to get codecoverage and report it using
    codecov
    Ketan Umare authored Apr 24, 2019
    Copy the full SHA
    6714d5f View commit details
  9. More Badges: Activity, Code coverage, report card (#15)

    * More badges for activity reporting
    
    * no links for activity
    Ketan Umare authored Apr 24, 2019
    Copy the full SHA
    1b96fb4 View commit details

Commits on Apr 26, 2019

  1. Fix Godownloader generated script (#14)

    * Add godownloader script
    
    * Update README.md
    
    * typo
    
    * Fix generated godownloader script
    
    * Default download to /Users/hamabuelfutuh/src/go/bin
    EngHabu authored Apr 26, 2019
    Copy the full SHA
    f99988b View commit details

Commits on Apr 30, 2019

  1. Race condition in logger.SetConfig (#16)

    * remove globalconfig variable to avoid data race
    
    * Add WithRoutineLabel
    
    * rename
    
    * simplify logger a bit
    
    * format
    
    * doc
    EngHabu authored Apr 30, 2019
    Copy the full SHA
    a12bdcf View commit details
  2. Copy the full SHA
    6ed22f3 View commit details

Commits on May 6, 2019

  1. Copy the full SHA
    35afe44 View commit details

Commits on May 8, 2019

  1. InitialzePFlags doesn't add flags for sub-sections (#17)

    * Allow InitializePFlags to recursively discover sub-section flags
    
    * Add unit test
    EngHabu authored May 8, 2019
    Copy the full SHA
    be32824 View commit details
Showing 4,200 changed files with 755,127 additions and 67,406 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
4 changes: 4 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
docs/**/*html linguist-generated=true
flyteidl/gen/** linguist-generated=true
flyteidl/protos/**/*.rst linguist-generated=true
flyteidl/clients/go/assets/admin.swagger.json linguist-generated=true

62 changes: 44 additions & 18 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,38 +1,64 @@
## Tracking issue
<!--
Thank you for sending the PR!
Please fill the applicable details below
Happy contributing!
-->
If your PR fixes an open issue, use `Closes #999` to link your PR with the issue.
Example: Closes #999
## Tracking issue
If your PR is related to an issue or PR, use `Related to #999` to link your PR.
Example: Related to #999
<!-- If your PR fixes an open issue, use `Closes #999` to link your PR with the issue. #999 stands for the issue number you are fixing -->
Remove this section if not applicable
-->

<!-- Remove this section if not applicable -->
## Why are the changes needed?

<!-- Example: Closes #31 -->
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->

## Describe your changes
## What changes were proposed in this pull request?

<!-- List all the proposed changes in your PR -->
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is design documentation, please add the link.
-->

## How was this patch tested?

<!-- Mark all the applicable boxes. To mark the box as done follow the following conventions -->
<!--
[x] - Correct; marked as done
[X] - Correct; marked as done
[ ] - Not correct; marked as **not** done
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
### Labels

Please add one or more of the following labels to categorize your PR:
- **added**: For new features.
- **changed**: For changes in existing functionality.
- **deprecated**: For soon-to-be-removed features.
- **removed**: For features being removed.
- **fixed**: For any bug fixed.
- **security**: In case of vulnerabilities

This is important to improve the readability of release notes.

### Setup process

### Screenshots

## Check all the applicable boxes <!-- Follow the above conventions to check the box -->

- [ ] I updated the documentation accordingly.
- [ ] All new and existing tests passed.
- [ ] All commits are signed-off.

## Screenshots
## Related PRs

<!-- Add all the screenshots which support your changes -->
<!-- Add related pull requests for reviewers to check -->

## Note to reviewers
## Docs link

<!-- Add notes to reviewers if applicable -->
<!-- Add documentation link built by CI jobs here, and specify the changed place -->
11 changes: 11 additions & 0 deletions .github/actions/clear-action-cache/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: 'Clear action cache'
description: 'As suggested by GitHub to prevent low disk space: https://github.com/actions/runner-images/issues/2840#issuecomment-790492173'
runs:
using: 'composite'
steps:
- shell: bash
run: |
rm -rf /usr/share/dotnet
rm -rf /opt/ghc
rm -rf "/usr/local/share/boost"
rm -rf "$AGENT_TOOLSDIRECTORY"
11 changes: 11 additions & 0 deletions .github/codespell-ignored-words
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
ThirdParty
bootup
crate
fo
lightyear
nd
notin
querys
ser
te
updAt
175 changes: 175 additions & 0 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,175 @@
name: Components Checks

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
cancel-in-progress: true

on:
pull_request:
push:
branches:
- master
- 'release-v**'
env:
GO_VERSION: "1.22"
PRIORITIES: "P0"
jobs:
unpack-envvars:
runs-on: ubuntu-latest
outputs:
go-version: ${{ steps.step.outputs.go-version }}
steps:
- id: step
run: |
echo "go-version=${{ env.GO_VERSION }}" >> $GITHUB_OUTPUT
lint:
name: Lint
needs:
- unpack-envvars
strategy:
fail-fast: false
matrix:
component:
- datacatalog
- flyteadmin
- flytecopilot
- flytectl
- flyteidl
- flyteplugins
- flytepropeller
- flytestdlib
uses: ./.github/workflows/lint.yml
with:
component: ${{ matrix.component }}
go-version: ${{ needs.unpack-envvars.outputs.go-version }}
unit-tests:
name: Unit Tests
needs:
- unpack-envvars
strategy:
fail-fast: false
matrix:
component:
- datacatalog
- flyteadmin
- flytecopilot
- flytectl
- flyteplugins
- flytepropeller
- flytestdlib
uses: ./.github/workflows/unit-tests.yml
with:
component: ${{ matrix.component }}
go-version: ${{ needs.unpack-envvars.outputs.go-version }}
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

flyteadmin-int-tests-image-build:
strategy:
fail-fast: false
name: flyteadmin integration tests image
uses: ./.github/workflows/component_docker_build.yml
with:
component: flyteadmin

flyteadmin-integration-tests:
name: Integration Test
needs:
- flyteadmin-int-tests-image-build
- unpack-envvars
strategy:
fail-fast: false
matrix:
component:
- flyteadmin
uses: ./.github/workflows/integration.yml
with:
component: ${{ matrix.component }}
cache_key: ${{ needs.flyteadmin-int-tests-image-build.outputs.cache_key }}
go-version: ${{ needs.unpack-envvars.outputs.go-version }}

generate:
name: Check Go Generate
needs:
- unpack-envvars
strategy:
fail-fast: false
matrix:
component:
- datacatalog
- flyteadmin
- flytecopilot
- flytectl
- flytepropeller
uses: ./.github/workflows/go_generate.yml
with:
component: ${{ matrix.component }}
go-version: ${{ needs.unpack-envvars.outputs.go-version }}
secrets:
FLYTE_BOT_PAT: ${{ secrets.FLYTE_BOT_PAT }}

build_docker_images:
name: Build Images
uses: ./.github/workflows/publish-images.yml
with:
push: false
secrets:
FLYTE_BOT_PAT: ${{ secrets.FLYTE_BOT_PAT }}
FLYTE_BOT_USERNAME: ${{ secrets.FLYTE_BOT_USERNAME }}

dry_run_goreleaser:
name: Dry Run Goreleaser
runs-on: ubuntu-latest
needs:
- unpack-envvars
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: "0"
- uses: actions/setup-go@v4
with:
go-version: ${{ needs.unpack-envvars.outputs.go-version }}
- name: Run GoReleaser dry run
uses: goreleaser/goreleaser-action@v5
with:
distribution: goreleaser-pro
version: latest
args: --snapshot --skip-publish --rm-dist -f flytectl/.goreleaser.yml
env:
GORELEASER_KEY: ${{ secrets.GORELEASER_KEY }}

sandbox:
name: Test Getting started
runs-on: ubuntu-latest
defaults:
run:
working-directory: flytectl
needs:
- unpack-envvars
steps:
- uses: insightsengineering/disk-space-reclaimer@v1
- name: Checkout
uses: actions/checkout@v2
- uses: actions/cache@v2
with:
path: |
~/.cache/go-build
~/go/pkg/mod
key: ${{ runner.os }}-go-${{ hashFiles('go.sum') }}
- name: Set up Go
uses: actions/setup-go@v4
with:
go-version: ${{ needs.unpack-envvars.outputs.go-version }}
- name: Build Flytectl binary
run: make compile
- name: Create a sandbox cluster
run: |
bin/flytectl demo start
- name: Setup flytectl config
run: bin/flytectl config init
- name: Register cookbook
run: bin/flytectl register examples -d development -p flytesnacks
- name: Teardown Sandbox cluster
run: bin/flytectl demo teardown
29 changes: 29 additions & 0 deletions .github/workflows/codespell.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
---
name: Codespell

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
cancel-in-progress: true

on:
push:
branches: [master]
pull_request:
branches: [master]

permissions:
contents: read

jobs:
codespell:
name: Check for spelling errors
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v4
- name: Codespell
uses: codespell-project/actions-codespell@v2
with:
skip: "*.pb,monodocs-environment.lock.yaml,.git,*.pdf,*.svg,go.sum,go.mod,*requirements.txt,gen"
ignore_words_file: .github/codespell-ignored-words
49 changes: 49 additions & 0 deletions .github/workflows/component_docker_build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
name: Build Docker Image

on:
workflow_call:
inputs:
component:
required: true
type: string
outputs:
cache_key:
description: "Docker Cache key"
value: ${{ jobs.build_docker.outputs.cache_key }}
jobs:
build_docker:
runs-on: ubuntu-latest
outputs:
cache_key: ${{ steps.cache_key.outputs.cache_key }}
steps:
- name: Checkout
uses: actions/checkout@v4
- id: load-docker-cache
name: Load Docker Cache
uses: actions/cache@v3
with:
path: /tmp/tmp/docker-images-${{ inputs.component }}
key: /tmp/docker-images-${{ github.run_id }}-${{ inputs.component }}
restore-keys: |
/tmp/docker-images-
- name: Set cache key output
id: cache_key
run: |
echo ::set-output name=cache_key::/tmp/docker-images-${{ github.run_id }}
- name: Prime docker cache
run: (docker load -i /tmp/tmp/docker-images/snapshot-builder.tar || true) && (docker load -i /tmp/tmp/docker-images/snapshot.tar || true)
- name: Build dockerfile
env:
# We are unable to leverage docker buildx here without changing the
# caching mechanism significantly. See here for the caching options
# available for docker buildx: https://docs.docker.com/engine/reference/commandline/buildx_build/#cache-from
# For now at least enable DOCKER_BUILDKIT for faster builds. Eventually we
# should rewrite this pipeline to use docker buildx with cache type=gha.
DOCKER_BUILDKIT: "1"
run: |
docker build -t ${{ github.repository_owner }}/${{ inputs.component }}:builder --target builder --cache-from=${{ github.repository_owner }}/${{ inputs.component }}:builder --file Dockerfile.${{ inputs.component }} .
docker build -t ${{ github.repository_owner }}/${{ inputs.component }}:latest --cache-from=${{ github.repository_owner }}/${{ inputs.component }}:builder --file Dockerfile.${{ inputs.component }} .
- name: Tag and cache docker image
run: |
mkdir -p /tmp/tmp/docker-images-${{ inputs.component }} && docker save ${{ github.repository_owner }}/${{ inputs.component }}:builder -o /tmp/tmp/docker-images-${{ inputs.component }}/snapshot-builder-${{ inputs.component }}.tar && docker save ${{ github.repository_owner }}/${{ inputs.component }}:latest -o /tmp/tmp/docker-images-${{ inputs.component }}/snapshot-${{ inputs.component }}.tar
Loading