-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass argument to kustomize script #14
Conversation
By accepting an argument, users of this script would be able to specify which deployment to build. Internally we have customized overlay which doesn't make sense to open source, but still we would like to utilize as much as possible from this repo.
@kumare3 PTAL whether this makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. BTW, I was thinking of creating a new base that is dependent on the base called Cloud base and creating one for GKE and one for EKS #12
Would you be open to contribute the non Spotify relevant parts to it?
Sure. Let's do that. |
Can someone from your side merge this? No permission here. Thanks. |
Variable created would shadow external variable
* Add godownloader script * Update README.md * typo * Fix generated godownloader script * Default download to /Users/hamabuelfutuh/src/go/bin
* Update Gopkg.toml * bump go version * copying changes from admin * lint * lint spelling
Signed-off-by: Yuvraj <[email protected]>
Variable created would shadow external variable
* Add godownloader script * Update README.md * typo * Fix generated godownloader script * Default download to /Users/hamabuelfutuh/src/go/bin
* Update Gopkg.toml * bump go version * copying changes from admin * lint * lint spelling
Signed-off-by: Yuvraj <[email protected]>
- [X] Retryable Dynamic Nodes - [X] RunToCompletion Workflow
Signed-off-by: Eduardo Apolinario <[email protected]>
- Missing entities are rendered as nil, instead of empty
- Missing entities are rendered as nil, instead of empty
- Missing entities are rendered as nil, instead of empty
By accepting an argument, users of this script would be able to specify
which deployment to build.
Internally we have customized overlay which doesn't make sense to
open source, but still we would like to utilize as much as possible from
this repo.