Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass argument to kustomize script #14

Merged
merged 1 commit into from
Nov 11, 2019

Conversation

honnix
Copy link
Member

@honnix honnix commented Nov 11, 2019

By accepting an argument, users of this script would be able to specify
which deployment to build.

Internally we have customized overlay which doesn't make sense to
open source, but still we would like to utilize as much as possible from
this repo.

By accepting an argument, users of this script would be able to specify
which deployment to build.

Internally we have customized overlay which doesn't make sense to
open source, but still we would like to utilize as much as possible from
this repo.
@honnix
Copy link
Member Author

honnix commented Nov 11, 2019

@kumare3 PTAL whether this makes sense.

@kumare3 kumare3 self-requested a review November 11, 2019 16:55
Copy link
Contributor

@kumare3 kumare3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. BTW, I was thinking of creating a new base that is dependent on the base called Cloud base and creating one for GKE and one for EKS #12
Would you be open to contribute the non Spotify relevant parts to it?

@honnix
Copy link
Member Author

honnix commented Nov 11, 2019

Sure. Let's do that.

@honnix
Copy link
Member Author

honnix commented Nov 11, 2019

Can someone from your side merge this? No permission here. Thanks.

@wild-endeavor wild-endeavor merged commit 88cf36b into flyteorg:master Nov 11, 2019
@honnix honnix deleted the deployment-option branch September 2, 2020 20:16
eapolinario referenced this pull request in eapolinario/flyte Dec 6, 2022
Variable created would shadow external variable
eapolinario referenced this pull request in eapolinario/flyte Dec 6, 2022
eapolinario referenced this pull request in eapolinario/flyte Dec 20, 2022
* Add godownloader script

* Update README.md

* typo

* Fix generated godownloader script

* Default download to /Users/hamabuelfutuh/src/go/bin
eapolinario referenced this pull request in eapolinario/flyte Dec 20, 2022
* Update Gopkg.toml

* bump go version

* copying changes from admin

* lint

* lint spelling
eapolinario referenced this pull request in eapolinario/flyte Dec 20, 2022
eapolinario referenced this pull request in eapolinario/flyte Aug 9, 2023
Variable created would shadow external variable
eapolinario referenced this pull request in eapolinario/flyte Aug 21, 2023
* Add godownloader script

* Update README.md

* typo

* Fix generated godownloader script

* Default download to /Users/hamabuelfutuh/src/go/bin
eapolinario referenced this pull request in eapolinario/flyte Aug 21, 2023
* Update Gopkg.toml

* bump go version

* copying changes from admin

* lint

* lint spelling
eapolinario referenced this pull request in eapolinario/flyte Aug 21, 2023
eapolinario pushed a commit that referenced this pull request Sep 8, 2023
eapolinario pushed a commit that referenced this pull request Sep 12, 2023
- [X] Retryable Dynamic Nodes
- [X] RunToCompletion Workflow
eapolinario pushed a commit that referenced this pull request Sep 13, 2023
Signed-off-by: Eduardo Apolinario <[email protected]>
wild-endeavor added a commit that referenced this pull request Oct 11, 2023
eapolinario pushed a commit that referenced this pull request Apr 30, 2024
- Missing entities are rendered as nil, instead of empty
austin362667 pushed a commit to austin362667/flyte that referenced this pull request May 7, 2024
- Missing entities are rendered as nil, instead of empty
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
- Missing entities are rendered as nil, instead of empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants