Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support lists in the Launch UI #154

Closed
schottra opened this issue Jan 8, 2020 · 1 comment
Closed

Support lists in the Launch UI #154

schottra opened this issue Jan 8, 2020 · 1 comment
Assignees
@schottra
Labels
pri1 ui Admin console user interface
Milestone
0.2.0

Comments

@schottra
Copy link
Contributor

schottra commented Jan 8, 2020

This task is to support entering list/collection values in the Launch UI.
For the initial implementation, collections can be entered as JSON-parseable array strings. Collections, by convention, are homogenous. So assuming that we can correctly parse the array string, the values in the array can all be run through the same sub-validator.
@schottra schottra added Task pri1 ui Admin console user interface labels Jan 8, 2020
@schottra schottra self-assigned this Jan 8, 2020
@schottra
Copy link
Contributor Author

schottra commented Jan 8, 2020

This is implemented by flyteorg/flyteconsole#33

@kumare3 kumare3 added this to the 0.2.0 milestone Mar 30, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@anandswaminathan
Bump up flytestdlib (flyteorg#154)
cc82192
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@yindia
Added version in flyteadmin (flyteorg#154)
19af628 
* wip: added version pkg

Signed-off-by: yuvraj <[email protected]>

* wip: resolve conflict

Signed-off-by: yuvraj <[email protected]>

* wip: added version in rpc

Signed-off-by: yuvraj <[email protected]>

* wip: small fixes

Signed-off-by: yuvraj <[email protected]>

* wip: Added panic cache in get version service

Signed-off-by: yuvraj <[email protected]>

* Added flytestdlib for version package

Signed-off-by: yuvraj <[email protected]>

* Added version service test

Signed-off-by: yuvraj <[email protected]>

* wip: added ldflags in goreleaser

Signed-off-by: yuvraj <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@EngHabu @pmahindrakar-oss
@anandswaminathan @jeevb @yindia @flyte-bot
[Breaking] OAuth2 Authorization Server implementation, Separate OpenI…
611a85f 
…D and OAuth2 configs, OAuth2 Metadata over gRPC #minor (flyteorg#168)

* wip: OAuth2 Support

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* wip

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* wip

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* tighten security of generated tokens

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Support storing form post values in auth code JWT

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* save secrets to k8s secrets

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Expose metadata endpoints over gRPC

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* trim OpenID Connect config further

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Selectively authenticate gRPC endpoints

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Support external oauth2 server and Okta Config

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* update config

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix nil secrets data map

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fixed the pointer overwrite issue in oauthServer metadata (flyteorg#183)

Signed-off-by: Prafulla Mahindrakar <[email protected]>

Co-authored-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Unit tests

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Unit tests

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Simplify config further and move auth package up

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix clusterresource Project and domain(flyteorg#167)

* Fix clusterresource Project

Signed-off-by: Anand Swaminathan <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Bump flyteidl version to pick up auth role field number fix (flyteorg#169)

Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Add option to use project name as namespace for the task pods (flyteorg#166)

* Add option to use project name as namespace for the task pods

Signed-off-by: Jeev B <[email protected]>

* rename

Signed-off-by: Jeev B <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>

* GetExecution performance improvements (flyteorg#171)

Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Add exists check for workflow & node executions (flyteorg#172)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Remove legacy fetch for workflow execution inputs (flyteorg#173)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Added release workflow (flyteorg#170)

Signed-off-by: yuvraj <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update Flyteidl version (flyteorg#175)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Added version in flyteadmin (flyteorg#154)

* wip: added version pkg

Signed-off-by: yuvraj <[email protected]>

* wip: resolve conflict

Signed-off-by: yuvraj <[email protected]>

* wip: added version in rpc

Signed-off-by: yuvraj <[email protected]>

* wip: small fixes

Signed-off-by: yuvraj <[email protected]>

* wip: Added panic cache in get version service

Signed-off-by: yuvraj <[email protected]>

* Added flytestdlib for version package

Signed-off-by: yuvraj <[email protected]>

* Added version service test

Signed-off-by: yuvraj <[email protected]>

* wip: added ldflags in goreleaser

Signed-off-by: yuvraj <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Propagate nesting and principal for child executions (flyteorg#177)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Write workflow and node execution events asynchronously (flyteorg#174)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Add sensible flyteadmin config defaults (flyteorg#179)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Lint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* further cleanup

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Only register authserver when auth is enabled

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update to latest flyteidl and separate auth interfaces

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* dead code

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* PR Comments

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* merge master

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Move to authorizedUris

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update to released flyteidl

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix response expiry and add unit tests

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update go mod

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* fix unit tests that broke because of identity changes

Signed-off-by: Haytham Abuelfutuh <[email protected]>

Co-authored-by: pmahindrakar-oss <[email protected]>
Co-authored-by: Prafulla Mahindrakar <[email protected]>
Co-authored-by: Anand Swaminathan <[email protected]>
Co-authored-by: Katrina Rogan <[email protected]>
Co-authored-by: Jeev B <[email protected]>
Co-authored-by: Yuvraj <[email protected]>
Co-authored-by: Flyte Bot <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@regadas
Add support for custom KubeClient (flyteorg#154)
3a6c640 
* Add support for custom KubeClient

Signed-off-by: Filipe Regadas <[email protected]>

* review

Signed-off-by: Filipe Regadas <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@mayitbeegh
Render descriptions in flytectl (flyteorg#154)
ae47fec
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@anandswaminathan
Bump up flytestdlib (flyteorg#154)
f9f3c3e
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@regadas
Add support for custom KubeClient (flyteorg#154)
cef76a8 
* Add support for custom KubeClient

Signed-off-by: Filipe Regadas <[email protected]>

* review

Signed-off-by: Filipe Regadas <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@yindia
Added version in flyteadmin (flyteorg#154)
20eac09 
* wip: added version pkg

Signed-off-by: yuvraj <[email protected]>

* wip: resolve conflict

Signed-off-by: yuvraj <[email protected]>

* wip: added version in rpc

Signed-off-by: yuvraj <[email protected]>

* wip: small fixes

Signed-off-by: yuvraj <[email protected]>

* wip: Added panic cache in get version service

Signed-off-by: yuvraj <[email protected]>

* Added flytestdlib for version package

Signed-off-by: yuvraj <[email protected]>

* Added version service test

Signed-off-by: yuvraj <[email protected]>

* wip: added ldflags in goreleaser

Signed-off-by: yuvraj <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@EngHabu @pmahindrakar-oss
@anandswaminathan @jeevb @yindia @flyte-bot
[Breaking] OAuth2 Authorization Server implementation, Separate OpenI…
435f520 
…D and OAuth2 configs, OAuth2 Metadata over gRPC #minor (flyteorg#168)

* wip: OAuth2 Support

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* wip

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* wip

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* tighten security of generated tokens

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Support storing form post values in auth code JWT

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* save secrets to k8s secrets

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Expose metadata endpoints over gRPC

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* trim OpenID Connect config further

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Selectively authenticate gRPC endpoints

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Support external oauth2 server and Okta Config

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* update config

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix nil secrets data map

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fixed the pointer overwrite issue in oauthServer metadata (flyteorg#183)

Signed-off-by: Prafulla Mahindrakar <[email protected]>

Co-authored-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Unit tests

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Unit tests

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Simplify config further and move auth package up

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix clusterresource Project and domain(flyteorg#167)

* Fix clusterresource Project

Signed-off-by: Anand Swaminathan <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Bump flyteidl version to pick up auth role field number fix (flyteorg#169)

Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Add option to use project name as namespace for the task pods (flyteorg#166)

* Add option to use project name as namespace for the task pods

Signed-off-by: Jeev B <[email protected]>

* rename

Signed-off-by: Jeev B <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>

* GetExecution performance improvements (flyteorg#171)

Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Add exists check for workflow & node executions (flyteorg#172)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Remove legacy fetch for workflow execution inputs (flyteorg#173)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Added release workflow (flyteorg#170)

Signed-off-by: yuvraj <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update Flyteidl version (flyteorg#175)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Added version in flyteadmin (flyteorg#154)

* wip: added version pkg

Signed-off-by: yuvraj <[email protected]>

* wip: resolve conflict

Signed-off-by: yuvraj <[email protected]>

* wip: added version in rpc

Signed-off-by: yuvraj <[email protected]>

* wip: small fixes

Signed-off-by: yuvraj <[email protected]>

* wip: Added panic cache in get version service

Signed-off-by: yuvraj <[email protected]>

* Added flytestdlib for version package

Signed-off-by: yuvraj <[email protected]>

* Added version service test

Signed-off-by: yuvraj <[email protected]>

* wip: added ldflags in goreleaser

Signed-off-by: yuvraj <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Propagate nesting and principal for child executions (flyteorg#177)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Write workflow and node execution events asynchronously (flyteorg#174)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Add sensible flyteadmin config defaults (flyteorg#179)

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Lint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* further cleanup

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Only register authserver when auth is enabled

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update to latest flyteidl and separate auth interfaces

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* dead code

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* PR Comments

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* merge master

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Move to authorizedUris

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update to released flyteidl

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Fix response expiry and add unit tests

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update go mod

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* fix unit tests that broke because of identity changes

Signed-off-by: Haytham Abuelfutuh <[email protected]>

Co-authored-by: pmahindrakar-oss <[email protected]>
Co-authored-by: Prafulla Mahindrakar <[email protected]>
Co-authored-by: Anand Swaminathan <[email protected]>
Co-authored-by: Katrina Rogan <[email protected]>
Co-authored-by: Jeev B <[email protected]>
Co-authored-by: Yuvraj <[email protected]>
Co-authored-by: Flyte Bot <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@mayitbeegh
Render descriptions in flytectl (flyteorg#154)
eaeb998
pmahindrakar-oss pushed a commit that referenced this issue May 1, 2024
@squiishyy
Histogram Bucket Options (#154)
44b48c8 
## Overview
Add abstraction to be able to pass buckets custom defined to histogram vectors.

Cherry picked a few changes from OSS into here as well
- [Update spark-on-k8s-operator address in helm charts ](0b1253b)
- [Fix wrong syntax for path filtering in validate-helm-charts.yaml](d5784e5)

## Test Plan
Unit tests, will be utilizing this in artifacts.

## Rollout Plan (if applicable)
Is currently unused, merging to master and consuming in [this PR](unionai/cloud#6851)

## Upstream Changes
Should this change be upstreamed to OSS (flyteorg/flyte)? If so, please check this box for auditing. Note, this is the responsibility of each developer. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F).
- [x] To be upstreamed

## Jira Issue
https://unionai.atlassian.net/browse/DX-647

## Checklist
* [ ] Added tests
* [ ] Ran a deploy dry run and shared the terraform plan
* [ ] Added logging and metrics
* [ ] Updated [dashboards](https://unionai.grafana.net/dashboards) and [alerts](https://unionai.grafana.net/alerting/list)
* [ ] Updated documentation
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@mayitbeegh @austin362667
Render descriptions in flytectl (flyteorg#154)
574b2f1
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@mayitbeegh @robert-ulbrich-mercedes-benz
Render descriptions in flytectl (flyteorg#154)
c754b4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schottra schottra

Labels
pri1 ui Admin console user interface
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
2 participants
@schottra @kumare3