-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Update tuple output examples in flytesnacks/flytekit docs #1710
Comments
@cosmicBboy Can I take this one? |
@Qiwen-Yu yes! let me assign you. Also let me know if you need any help setting your repo up. Examples in both flytekit and flytesnacks probably need to be updated. |
Correct me if I were wrong, the scope is to fix all |
yep, that's correct! |
@cosmicBboy Hi, I'm still working on this. |
cool! don't hesitate to reach out if you need anything |
fix issue flyteorg#1710, flyteorg/flyte#1710 update typing hints for tuple
fix issue flyteorg#1710 flyteorg/flyte#1710 change typing hints from ( , ) to Tuple[ , ]
@cosmicBboy Hi, I've made several changes. |
fix issue flyteorg#1710 flyteorg/flyte#1710 change typing hints from ( , ) to Tuple[ , ] Signed-off-by: Qiwen Yu <[email protected]>
fix issue flyteorg#1710, flyteorg/flyte#1710 update typing hints for tuple Signed-off-by: Qiwen Yu <[email protected]>
fix issue flyteorg#1710 flyteorg/flyte#1710 change typing hints from ( , ) to Tuple[ , ] Signed-off-by: Qiwen Yu <[email protected]>
* update task cache docs (#459) Signed-off-by: Niels Bantilan <[email protected]> Signed-off-by: Qiwen Yu <[email protected]> * update typing for Tuple fix issue #1710 flyteorg/flyte#1710 change typing hints from ( , ) to Tuple[ , ] Signed-off-by: Qiwen Yu <[email protected]> * update more Tuple typing hints Signed-off-by: Qiwen Yu <[email protected]> Co-authored-by: Niels Bantilan <[email protected]>
* update task cache docs (#459) Signed-off-by: Niels Bantilan <[email protected]> Signed-off-by: Qiwen Yu <[email protected]> * update typing for Tuple fix issue #1710 flyteorg/flyte#1710 change typing hints from ( , ) to Tuple[ , ] Signed-off-by: Qiwen Yu <[email protected]> * update more Tuple typing hints Signed-off-by: Qiwen Yu <[email protected]> Co-authored-by: Niels Bantilan <[email protected]>
Description
currently our docs have output function sigs for tuples as
We added support for the correct syntax:
The purpose of this issue is to update all instances of the former to the latter
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: