You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
bugSomething isn't workingflytekitFlyteKit Python related issuepluginsPlugins related labels (backend or frontend)untriagedThis issues has not yet been looked at by the Maintainers
Currently, in pytorch/tensorflow flytekit plugin, We override the resource limit passed in the task decorator, These plugins it's their own parameter for defining the limit but that is wrong.
Are you sure this issue hasn't been raised already?
Yes
Have you read the Code of Conduct?
Yes
The text was updated successfully, but these errors were encountered:
yindia
added
bug
Something isn't working
untriaged
This issues has not yet been looked at by the Maintainers
flytekit
FlyteKit Python related issue
plugins
Plugins related labels (backend or frontend)
labels
Oct 28, 2021
bugSomething isn't workingflytekitFlyteKit Python related issuepluginsPlugins related labels (backend or frontend)untriagedThis issues has not yet been looked at by the Maintainers
Describe the bug
Currently, in pytorch/tensorflow flytekit plugin, We override the resource limit passed in the task decorator, These plugins it's their own parameter for defining the limit but that is wrong.
Here we are doing override
https://github.com/flyteorg/flytekit/blob/master/plugins/flytekit-kf-tensorflow/flytekitplugins/kftensorflow/task.py#L56
Expected behavior
pytorch/tensorflow flytekit plugin should use a task decorator for defining the limit. We did it in mpi plugin https://github.com/flyteorg/flytekit/blob/master/plugins/flytekit-kf-mpi/flytekitplugins/kfmpi/task.py#L116
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: