Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] pytorch/tensorflow plugin over ride the resource limit passed in task decorator #1758

Closed
2 tasks done
yindia opened this issue Oct 28, 2021 · 0 comments · Fixed by flyteorg/flytesnacks#466
Closed
2 tasks done
Labels
bug Something isn't working flytekit FlyteKit Python related issue plugins Plugins related labels (backend or frontend) untriaged This issues has not yet been looked at by the Maintainers

Comments

@yindia
Copy link
Contributor

yindia commented Oct 28, 2021

Describe the bug

Currently, in pytorch/tensorflow flytekit plugin, We override the resource limit passed in the task decorator, These plugins it's their own parameter for defining the limit but that is wrong.

Here we are doing override
https://github.com/flyteorg/flytekit/blob/master/plugins/flytekit-kf-tensorflow/flytekitplugins/kftensorflow/task.py#L56

Expected behavior

pytorch/tensorflow flytekit plugin should use a task decorator for defining the limit. We did it in mpi plugin https://github.com/flyteorg/flytekit/blob/master/plugins/flytekit-kf-mpi/flytekitplugins/kfmpi/task.py#L116

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@yindia yindia added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers flytekit FlyteKit Python related issue plugins Plugins related labels (backend or frontend) labels Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue plugins Plugins related labels (backend or frontend) untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant