Refactor resource limit in pytorch/tensorflow plugin #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yindia
requested review from
eapolinario,
kumare3 and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
=======================================
Coverage 85.78% 85.78%
=======================================
Files 362 362
Lines 30007 30007
Branches 2444 2444
=======================================
Hits 25743 25743
Misses 3621 3621
Partials 643 643 Continue to review full report at Codecov.
|
Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
wild-endeavor
approved these changes
Oct 28, 2021
eapolinario
approved these changes
Oct 28, 2021
katrogan
reviewed
Oct 28, 2021
reverson
pushed a commit
to reverson/flytekit
that referenced
this pull request
May 27, 2022
* Refactor resource limit in pytorch/tensorflow plugin Signed-off-by: Yuvraj <[email protected]> Signed-off-by: Robert Everson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Refactor resource limit in pytorch/tensorflow plugin
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#1758
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/