Generate Java gPRC stub #178
Comments
|
@kumare3 wdyt? |
|
@honnix absolutely, we should be open sourcing it. I think I am also open to just starting a new repo outside and we can copy things over. Then use this open sourced alternative. Open sourcing sometimes can take too long. |
|
I have moved it to milestone 3. I will work on this after tomorrow |
|
@honnix Is this done as part of your https://github.com/spotify/flytekit-java OSS. Can we close this? |
|
Yes it is done there. However it is still strange we don't generate stub here. flytekit-java as I remember doesn't distribute proto and rpc generated code. I will take a look at there first. There is an ongoing PR in protocgenerator, and I think we could get Java fixed with little effort. |
|
@honnix let me know if we should start merging the PR |
* Node execution refactor for Parent-child relationship * Test fixes * Comments and test
…lyteorg#178) Signed-off-by: Katrina Rogan <[email protected]>
make the index page contain the user guide intro content Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: Pianist038801 <[email protected]> Co-authored-by: Pianist038801 <[email protected]>
# [0.22.0](http://github.com/lyft/flyteconsole/compare/v0.21.0...v0.22.0) (2021-08-04) ### Features * add enum input type in launch form ([flyteorg#178](http://github.com/lyft/flyteconsole/issues/178)) ([847461f](http://github.com/lyft/flyteconsole/commit/847461f5339921e1a2f68512057a38d8a495a814))
* Node execution refactor for Parent-child relationship * Test fixes * Comments and test
…lyteorg#178) Signed-off-by: Katrina Rogan <[email protected]>
|
Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏 |
|
Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏 |
|
This has been completed |
|
Do we have the gRPC stubs generated for Java? I don't see them here https://github.com/flyteorg/flyte/tree/master/flyteidl/gen/pb-java/flyteidl/service. Also it would be nice to get those generated classes compiled, packed and uploaded to Maven central. Unlike Go, Java doesn't do source code distribution. |
) (#178) ## Overview Cherry-pick of [3fe4533](3fe4533) and [c21ded6](c21ded6) as well as code changes to be org-aware ## Test Plan *TODO: Summarize tests added, integration tests run, or other steps you took to validate this change. Include (or link to) relevant test output or screenshots.* ## Rollout Plan (if applicable) *TODO: Describe any deployment or compatibility considerations for rolling out this change.* ## Upstream Changes Should this change be upstreamed to OSS (flyteorg/flyte)? If so, please check this box for auditing. Note, this is the responsibility of each developer. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F). - [ ] To be upstreamed ## Jira Issue https://unionai.atlassian.net/browse/<project-number> ## Checklist * [ ] Added tests * [ ] Ran a deploy dry run and shared the terraform plan * [ ] Added logging and metrics * [ ] Updated [dashboards](https://unionai.grafana.net/dashboards) and [alerts](https://unionai.grafana.net/alerting/list) * [ ] Updated documentation
Currently the docker image that is used to generate Java code from proto doesn't generate gPRC stub.
This is easily solvable by installing one more binary and tweak it a bit. To do that we will need to open source the image.
The text was updated successfully, but these errors were encountered: