Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Branch Nodes in FlyteKit #231

Closed
1 of 13 tasks
EngHabu opened this issue Mar 30, 2020 · 1 comment
Closed
1 of 13 tasks

Implement Branch Nodes in FlyteKit #231

EngHabu opened this issue Mar 30, 2020 · 1 comment
Assignees
@kumare3
Labels
enhancement New feature or request pri1
Milestone
0.11.0

Comments

@EngHabu
Copy link
Contributor

EngHabu commented Mar 30, 2020

Motivation: Why do you think this is important?
Statically declared WF branching allows users to write more concise flow control logic that can be visualized/debugged/analyzed statically.

Goal: What should the final outcome look like, ideally?
A pythonic-way of defining branches within a workflow that implements the full flyte IDL spec.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

[Optional] Propose: Link/Inline

n1 = get_int(...)
node = flyte_if(n1).EqualsTo(5).then(task_1(...))
             .else_if().GreaterThan(10).then(lp_2(...))
             .else(default_case(...))
@EngHabu EngHabu added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Mar 30, 2020
@kumare3 kumare3 added pri1 and removed untriaged This issues has not yet been looked at by the Maintainers labels Mar 31, 2020
@kumare3 kumare3 mentioned this issue Apr 14, 2020
Closed
@kumare3 kumare3 added this to the 0.11.0 milestone Jan 29, 2021
@kumare3 kumare3 self-assigned this Jan 29, 2021
@kumare3
Copy link
Contributor

kumare3 commented Jan 29, 2021

This is now part of v0.16.0b1

@kumare3 kumare3 closed this as completed Jan 29, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@EngHabu
Make task limits default == platform defaults (flyteorg#231)
e6e6576 
Signed-off-by: Haytham Abuelfutuh <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@hamersaw
Track RetryAttempt and Phase of ExternalResources (flyteorg#231)
0637c34 
* replaced Metadata proto in TaskInfo with ExternalResource array

Signed-off-by: Daniel Rammer <[email protected]>

* added ExternalResource documentation comments

Signed-off-by: Daniel Rammer <[email protected]>

* setting retry attempt on external resources

Signed-off-by: Daniel Rammer <[email protected]>

* fixed unit tests and lint issues

Signed-off-by: Daniel Rammer <[email protected]>

* tracking RetryAttempt for k8s array plugin using a CompactArray

Signed-off-by: Daniel Rammer <[email protected]>

* added a few comments

Signed-off-by: Daniel Rammer <[email protected]>

* setting RetryAttempts for awsbatch subtasks

Signed-off-by: Daniel Rammer <[email protected]>

* fixed unit tests and lint issues

Signed-off-by: Daniel Rammer <[email protected]>

* populating external resource index with original index

Signed-off-by: Daniel Rammer <[email protected]>

* updated comments

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteidl version

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@SandraGH5 @samhita-alla
Update fast_registration.py (flyteorg#213)
28223a7 
* Update fast_registration.py

* update fast registration (flyteorg#216)

Signed-off-by: Samhita Alla <[email protected]>

* Modify TOC and add a mechanism to consider RST files  (flyteorg#218)

* update fast registration

Signed-off-by: Samhita Alla <[email protected]>

* modified TOC and added a mechanism to consider RST files

Signed-off-by: Samhita Alla <[email protected]>

* updated conf.py

Signed-off-by: Samhita Alla <[email protected]>

* modified TOC

Signed-off-by: Samhita Alla <[email protected]>

* edit fast registration (flyteorg#219)

Signed-off-by: Samhita Alla <[email protected]>

* Edit fast_registration.rst (flyteorg#220)

* edit fast registration

Signed-off-by: Samhita Alla <[email protected]>

* removed unnecessary RST file

Signed-off-by: Samhita Alla <[email protected]>

* Fix conflicts in flyteorg#213 (flyteorg#230)

Signed-off-by: Samhita Alla <[email protected]>

* Revert "Fix conflicts in flyteorg#213 (flyteorg#230)" (flyteorg#231)

This reverts commit 525fbbcfb8828ac2e0b6d75d637455bcff1b9d21.

Co-authored-by: Samhita Alla <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@yindia
bump version containerd (flyteorg#231)
aa48962 
Signed-off-by: Yuvraj <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@EngHabu
Make task limits default == platform defaults (flyteorg#231)
f3841f3 
Signed-off-by: Haytham Abuelfutuh <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@hamersaw
Track RetryAttempt and Phase of ExternalResources (flyteorg#231)
f594e15 
* replaced Metadata proto in TaskInfo with ExternalResource array

Signed-off-by: Daniel Rammer <[email protected]>

* added ExternalResource documentation comments

Signed-off-by: Daniel Rammer <[email protected]>

* setting retry attempt on external resources

Signed-off-by: Daniel Rammer <[email protected]>

* fixed unit tests and lint issues

Signed-off-by: Daniel Rammer <[email protected]>

* tracking RetryAttempt for k8s array plugin using a CompactArray

Signed-off-by: Daniel Rammer <[email protected]>

* added a few comments

Signed-off-by: Daniel Rammer <[email protected]>

* setting RetryAttempts for awsbatch subtasks

Signed-off-by: Daniel Rammer <[email protected]>

* fixed unit tests and lint issues

Signed-off-by: Daniel Rammer <[email protected]>

* populating external resource index with original index

Signed-off-by: Daniel Rammer <[email protected]>

* updated comments

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteidl version

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@yindia
bump version containerd (flyteorg#231)
073c29d 
Signed-off-by: Yuvraj <[email protected]>
pmahindrakar-oss pushed a commit that referenced this issue May 1, 2024
@squiishyy
Add read replica host config and connection (#231)
60d2dd4 
## Overview
- Add a new field to the postgres db config struct, `readReplicaHost`.
- Add a new endpoint in the `database` package to enable establishing a connection with a db without creating it if it doesn't exist

## Test Plan
- Unit tests and staging tests for artifacts db read replica connection
- Validate the new host name is correct: https://buildkite.com/unionai/artifacts-staging-deploy/builds/505#018f11f5-ea7f-47d0-b145-ca433159e3b4

## Rollout Plan (if applicable)
Staging -> canary -> prod

## Upstream Changes
Should this change be upstreamed to OSS (flyteorg/flyte)? If so, please check this box for auditing. Note, this is the responsibility of each developer. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F).
- [x] To be upstreamed

## Jira Issue
https://unionai.atlassian.net/browse/UNION-406

## Checklist
* [ ] Added tests
* [ ] Ran a deploy dry run and shared the terraform plan
* [ ] Added logging and metrics
* [ ] Updated [dashboards](https://unionai.grafana.net/dashboards) and [alerts](https://unionai.grafana.net/alerting/list)
* [ ] Updated documentation
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@yindia @austin362667
bump version containerd (flyteorg#231)
893b7c2 
Signed-off-by: Yuvraj <[email protected]>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@yindia @robert-ulbrich-mercedes-benz
bump version containerd (flyteorg#231)
368b893 
Signed-off-by: Yuvraj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumare3 kumare3

Labels
enhancement New feature or request pri1
Projects
None yet
Milestone
0.11.0
Development

No branches or pull requests
2 participants
@EngHabu @kumare3