You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The default version for the npm package generated from the flyteidl repository is specified as "develop" in the repo's package.json, which is not valid semver (and thus considered "invalid" by npm).
This seems to have been changed as part of automatic releases in #808, however the current default prevents the repository from being used as a git dependency by npm/yarn.
Whilst probably not the most pressing issue for the current development flow, this would e.g. allow for flyteconsole PRs to be opened using unreleased versions of flyteidl (if just to run CI steps/discuss changes) as is currently the case with go modules such as flyteadmin.
Furthermore, it would allow for (private) forks of flyteidl to be used as a dependency for flyteconsole without the requirement of publishing extra npm packages for every change.
A simple fix for this would be setting the version to "0.0.0-develop" (as is already the case in flytekit), still denoting an (unreleased) development version, but allowing for the repository to be used as a git dependency without issues.
I'm happy to send a tiny PR to flyteidl if so desired.
What if we do not do this?
flyteidl repository cannot be used as a (git) dependency during development/for unreleased changes. flyteconsole development + PRs will remain reliant on proposed flyteidl changes to be merged and published first.
Related component(s)
flyteidl, flyteconsole (indirect)
Are you sure this issue hasn't been raised already?
Yes
Have you read the Code of Conduct?
Yes
The text was updated successfully, but these errors were encountered:
Describe the issue
The default version for the npm package generated from the flyteidl repository is specified as
"develop"
in the repo'spackage.json
, which is not valid semver (and thus considered "invalid" by npm).This seems to have been changed as part of automatic releases in #808, however the current default prevents the repository from being used as a git dependency by npm/yarn.
Whilst probably not the most pressing issue for the current development flow, this would e.g. allow for flyteconsole PRs to be opened using unreleased versions of flyteidl (if just to run CI steps/discuss changes) as is currently the case with go modules such as flyteadmin.
Furthermore, it would allow for (private) forks of flyteidl to be used as a dependency for flyteconsole without the requirement of publishing extra npm packages for every change.
A simple fix for this would be setting the version to
"0.0.0-develop"
(as is already the case in flytekit), still denoting an (unreleased) development version, but allowing for the repository to be used as a git dependency without issues.I'm happy to send a tiny PR to flyteidl if so desired.
What if we do not do this?
flyteidl repository cannot be used as a (git) dependency during development/for unreleased changes. flyteconsole development + PRs will remain reliant on proposed flyteidl changes to be merged and published first.
Related component(s)
flyteidl, flyteconsole (indirect)
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: