Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Use valid default npm version in flyteidl #2408

Closed
2 tasks done
MorpheusXAUT opened this issue Apr 25, 2022 · 1 comment · Fixed by flyteorg/flyteidl#293
Closed
2 tasks done

[Housekeeping] Use valid default npm version in flyteidl #2408

MorpheusXAUT opened this issue Apr 25, 2022 · 1 comment · Fixed by flyteorg/flyteidl#293
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@MorpheusXAUT
Copy link
Contributor

Describe the issue

The default version for the npm package generated from the flyteidl repository is specified as "develop" in the repo's package.json, which is not valid semver (and thus considered "invalid" by npm).
This seems to have been changed as part of automatic releases in #808, however the current default prevents the repository from being used as a git dependency by npm/yarn.

Whilst probably not the most pressing issue for the current development flow, this would e.g. allow for flyteconsole PRs to be opened using unreleased versions of flyteidl (if just to run CI steps/discuss changes) as is currently the case with go modules such as flyteadmin.
Furthermore, it would allow for (private) forks of flyteidl to be used as a dependency for flyteconsole without the requirement of publishing extra npm packages for every change.

A simple fix for this would be setting the version to "0.0.0-develop" (as is already the case in flytekit), still denoting an (unreleased) development version, but allowing for the repository to be used as a git dependency without issues.

I'm happy to send a tiny PR to flyteidl if so desired.

What if we do not do this?

flyteidl repository cannot be used as a (git) dependency during development/for unreleased changes. flyteconsole development + PRs will remain reliant on proposed flyteidl changes to be merged and published first.

Related component(s)

flyteidl, flyteconsole (indirect)

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@MorpheusXAUT MorpheusXAUT added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Apr 25, 2022
@welcome
Copy link

welcome bot commented Apr 25, 2022

Thank you for opening your first issue here! 🛠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant