This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Change default npm/python versions to valid semver #patch #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Müller <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
=======================================
Coverage 74.77% 74.77%
=======================================
Files 15 15
Lines 991 991
=======================================
Hits 741 741
Misses 218 218
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
anrusina
approved these changes
Apr 26, 2022
katrogan
approved these changes
Apr 26, 2022
hamersaw
approved these changes
Apr 27, 2022
|
Congrats on merging your first pull request! 🎉 |
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
Signed-off-by: Nick Müller <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Updated the default (develop) version specified in
package.json/setup.pyfiles to contain valid semver.Type
Are all requirements met?
Complete description
The version specified for the npm/python package generated from flyteidl is set to
"develop", which is not valid semver format and leads to npm/yarn refusing to use the repository as a git dependency.This PR changes the default version to
0.0.0-developand0.0.0+developfor npm and python respectively, remaining the clear indication that anything packages from this is a development build while ensuring no accidental upgrades to this package will be performed as its version number is below anything published and the appended-+developmakes it a pre-release/local version with even lower priority.A similar setup already exists for the python package of the flytekit repository.
As mentioned in the issue, the main benefit of this would be PRs to flyteconsole using unreleased versions of flyteidl as well as the option for (private) forks of flyte to use the flyteidl repository as a direct dependency for npm (and potentially python, although untested).
Tracking Issue
fixes flyteorg/flyte#2408
Follow-up issue
NA