Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform-Specified Defaults for Configs #26

Closed
georgesnelling opened this issue Nov 19, 2019 · 1 comment
Closed

Platform-Specified Defaults for Configs #26

georgesnelling opened this issue Nov 19, 2019 · 1 comment
Assignees
@matthewphsmith
Labels
pri2

Comments

@georgesnelling
Copy link
Contributor

No description provided.

@EngHabu
Copy link
Contributor

EngHabu commented Jun 10, 2020

If by "Platform" it meant "s3, gcp... etc." I think that should be driven by the the execution plane not by the SDK (which I think what this implies).

@EngHabu EngHabu closed this as completed Jun 10, 2020
eapolinario referenced this issue in eapolinario/flyte Dec 20, 2022
@anandswaminathan
Set provider only if all methods are implemented (#26)
2577ff2 
* Set provider only if all methods of interface are implemented
eapolinario referenced this issue in eapolinario/flyte Dec 20, 2022
@surindersinghp
Delete sidecar pod when task completes. (#26)
3013158 
* Delete sidecar pod when task completes.

* missing comment

* Update plugin_executor.go

* Update plugin_executor.go

* in two steps

* fix

* Update plugin_executor.go

* test fixes

* tests

* bogus comment

* fixing k8s object state

* debug logs

* Update go/tasks/v1/flytek8s/k8splugin_state_test.go

Co-Authored-By: Haytham AbuelFutuh <[email protected]>

* cr feedback

* cr feedback

* cr feedback

* removing djo
eapolinario referenced this issue in eapolinario/flyte Dec 20, 2022
@chanadian
Make DatasetID optional for Get Artifact (#26)
328ff22 
* Allow getting artifact with just the artifactID

* Validate dataset only if it was passed
eapolinario referenced this issue in eapolinario/flyte Dec 20, 2022
@flyte-bot
Update Boilerplate (#26)
9dd8cae 
Signed-off-by: Flyte-Bot <[email protected]>

Co-authored-by: flyte-bot <[email protected]>
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
@anandswaminathan
Set provider only if all methods are implemented (#26)
00f5d1a 
* Set provider only if all methods of interface are implemented
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
@surindersinghp
Delete sidecar pod when task completes. (#26)
ca70572 
* Delete sidecar pod when task completes.

* missing comment

* Update plugin_executor.go

* Update plugin_executor.go

* in two steps

* fix

* Update plugin_executor.go

* test fixes

* tests

* bogus comment

* fixing k8s object state

* debug logs

* Update go/tasks/v1/flytek8s/k8splugin_state_test.go

Co-Authored-By: Haytham AbuelFutuh <[email protected]>

* cr feedback

* cr feedback

* cr feedback

* removing djo
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
@chanadian
Make DatasetID optional for Get Artifact (#26)
442e040 
* Allow getting artifact with just the artifactID

* Validate dataset only if it was passed
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
@flyte-bot
Update Boilerplate (#26)
2103c80 
Signed-off-by: Flyte-Bot <[email protected]>

Co-authored-by: flyte-bot <[email protected]>
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
@yindia
Fix welcome bot path (#26)
d0fd13c 
Signed-off-by: Yuvraj <[email protected]>
eapolinario pushed a commit that referenced this issue Sep 12, 2023
@wild-endeavor
Flytekit 0.16.0a0 (#26)
9c1be99
eapolinario referenced this issue in eapolinario/flyte Sep 26, 2023
@chanadian
Make DatasetID optional for Get Artifact (#26)
dbac744 
* Allow getting artifact with just the artifactID

* Validate dataset only if it was passed
eapolinario referenced this issue in eapolinario/flyte Apr 30, 2024
@kumare3
Documentation setup for FlyteCTL (#26)
f5a3544 
* Documentation setup for FlyteCTL

* Conf updated
eapolinario referenced this issue in eapolinario/flyte Apr 30, 2024
@kumare3
Documentation setup for FlyteCTL (#26)
62dfd32 
* Documentation setup for FlyteCTL

* Conf updated
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@kumare3 @austin362667
Documentation setup for FlyteCTL (flyteorg#26)
2ec8757 
* Documentation setup for FlyteCTL

* Conf updated
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@kumare3 @robert-ulbrich-mercedes-benz
Documentation setup for FlyteCTL (flyteorg#26)
5413a33 
* Documentation setup for FlyteCTL

* Conf updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewphsmith matthewphsmith

Labels
pri2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EngHabu @georgesnelling @matthewphsmith