Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Handle Failure node for Subworkflows #265

Closed
1 of 13 tasks
kumare3 opened this issue Apr 14, 2020 · 0 comments
Closed
1 of 13 tasks

[BUG] Handle Failure node for Subworkflows #265

kumare3 opened this issue Apr 14, 2020 · 0 comments
Assignees
@EngHabu
Labels
bug Something isn't working pri3 untriaged This issues has not yet been looked at by the Maintainers
Milestone
0.4.0

Comments

@kumare3
Copy link
Contributor

kumare3 commented Apr 14, 2020 •
edited
Loading

Motivation: Why do you think this is important?
SubWorkflows are like workflows. They both contain a failure node which will be triggered in case the workflow execution fails - like a try... catch. But this is not executed for Subworkflows (implemented for top level workflows)

Goal: What should the final outcome look like, ideally?
Ideally, a user should be able to define a failure node for a subworkflow and Propeller should handle it correctly

Describe alternatives you've considered
NA

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

[Optional] Propose: Link/Inline
This needs a new state in the nodes > Subworkflow > handler to handle a failing workflow.

Additional context
NA

Is this a blocker for you to adopt Flyte
NA
@kumare3 kumare3 added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Apr 14, 2020
@kumare3 kumare3 added this to the 0.5.0 milestone Apr 14, 2020
@kumare3 kumare3 changed the title [Missing Feature] Handle Failure node for Subworkflows [BUG] Handle Failure node for Subworkflows Apr 14, 2020
@kumare3 kumare3 added bug Something isn't working pri3 and removed enhancement New feature or request labels Apr 14, 2020
@EngHabu EngHabu self-assigned this May 18, 2020
@EngHabu EngHabu mentioned this issue May 21, 2020
Merged
7 tasks
@kumare3 kumare3 modified the milestones: 0.5.0, 0.4.0 Jun 10, 2020
@kumare3 kumare3 closed this as completed Jun 10, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@pmahindrakar-oss
Removed literals.go from propeller and reusing it from flyteidl (flyt…
78b35c2 
…eorg#265)

* Removed literals.go from propeller and reusing it from flyteidl

Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Fixed tests

Signed-off-by: Prafulla Mahindrakar <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@flyte-bot
Update Flyteidl version (flyteorg#265)
4ccd0af 
Signed-off-by: Flyte-Bot <[email protected]>

Co-authored-by: flyte-bot <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@SandraGH5
Update README.rst (flyteorg#265)
2c08c02
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@wild-endeavor
add port (flyteorg#265)
2827633 
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@govalt
feat: timeline view (flyteorg#265)
f499895
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@flyte-bot
chore(release): Release 0.43.0 [skip ci]
e5b7169 
# [0.43.0](http://github.com/lyft/flyteconsole/compare/v0.42.1...v0.43.0) (2022-02-15)

### Features

* timeline view ([flyteorg#265](http://github.com/lyft/flyteconsole/issues/265)) ([f499895](http://github.com/lyft/flyteconsole/commit/f499895fb99878766118634e2fe256a4dfa98a7e))
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@pmahindrakar-oss
Removed literals.go from propeller and reusing it from flyteidl (flyt…
e4821fc 
…eorg#265)

* Removed literals.go from propeller and reusing it from flyteidl

Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Fixed tests

Signed-off-by: Prafulla Mahindrakar <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@flyte-bot
Update Flyteidl version (flyteorg#265)
81f0a0a 
Signed-off-by: Flyte-Bot <[email protected]>

Co-authored-by: flyte-bot <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@wild-endeavor
add port (flyteorg#265)
dec585d 
Signed-off-by: Yee Hing Tong <[email protected]>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@wild-endeavor @austin362667
add port (flyteorg#265)
dbb00f5 
Signed-off-by: Yee Hing Tong <[email protected]>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@wild-endeavor @robert-ulbrich-mercedes-benz
add port (flyteorg#265)
11cba40 
Signed-off-by: Yee Hing Tong <[email protected]>
troychiu pushed a commit that referenced this issue Jul 8, 2024
@andrewwdye
Fix k3d local setup prefix (#265)
997a60d 
## Overview
I was trying to use `setup_local_dev.sh`, and it wasn't working out of the box. Looks like it expects `k3d-` prefix for the kubecontext

## Test Plan
Ran `setup_local_dev.sh`

## Rollout Plan (if applicable)
N/A

## Upstream Changes
Should this change be upstreamed to OSS (flyteorg/flyte)? If so, please check this box for auditing. Note, this is the responsibility of each developer. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F).
- [x] To be upstreamed

## Jira Issue
https://unionai.atlassian.net/browse/<project-number>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EngHabu EngHabu

Labels
bug Something isn't working pri3 untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
2 participants
@EngHabu @kumare3