Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] numpy 1.24.0 breaks flytekit #3167

Closed
2 tasks done
honnix opened this issue Dec 19, 2022 · 1 comment
Closed
2 tasks done

[BUG] numpy 1.24.0 breaks flytekit #3167

honnix opened this issue Dec 19, 2022 · 1 comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue
Milestone

Comments

@honnix
Copy link
Member

honnix commented Dec 19, 2022

Describe the bug

10:37:44.889  .tox/py38-test/lib/python3.8/site-packages/flytekit/__init__.py:195: in <module>
10:37:44.889      from flytekit.types import directory, file, numpy, schema
10:37:44.889  .tox/py38-test/lib/python3.8/site-packages/flytekit/types/schema/__init__.py:1: in <module>
10:37:44.889      from .types import (
10:37:44.889  .tox/py38-test/lib/python3.8/site-packages/flytekit/types/schema/types.py:314: in <module>
10:37:44.889      class FlyteSchemaTransformer(TypeTransformer[FlyteSchema]):
10:37:44.889  .tox/py38-test/lib/python3.8/site-packages/flytekit/types/schema/types.py:324: in FlyteSchemaTransformer
10:37:44.889      _np.bool: SchemaType.SchemaColumn.SchemaColumnType.BOOLEAN,  # type: ignore
10:37:44.889  .tox/py38-test/lib/python3.8/site-packages/numpy/__init__.py:284: in __getattr__
10:37:44.889      raise AttributeError("module {!r} has no attribute "
10:37:44.889  E   AttributeError: module 'numpy' has no attribute 'bool'

In numpy 1.24.0 release note:

The deprecation for the aliases np.object, np.bool, np.float,
np.complex, np.str, and np.int is expired (introduces NumPy
1.20). Some of these will now give a FutureWarning in addition to
raising an error since they will be mapped to the NumPy scalars in
the future.

Expected behavior

flytekit should work, either by pinning numpy or being compatible with 1.24.0

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@honnix honnix added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers flytekit FlyteKit Python related issue labels Dec 19, 2022
@honnix
Copy link
Member Author

honnix commented Dec 20, 2022

This duplicates #3166

@honnix honnix closed this as completed Dec 20, 2022
@wild-endeavor wild-endeavor removed the untriaged This issues has not yet been looked at by the Maintainers label Dec 20, 2022
@wild-endeavor wild-endeavor added this to the 1.3.0 milestone Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue
Projects
None yet
Development

No branches or pull requests

2 participants