-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Housekeeping] Remove deprecated numpy aliases #3166
Comments
So that the pyspark test doesn't fail. Why is it failing? Well it appears that ([source](flyteorg/flyte#3166)): > A few aliases defined in numpy were deprecated in v1.20.0 and finally removed in v1.24.0 And pyspark hasn't updated to not use it.
Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏 |
Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏 |
It looks like one of these changes has already been made in the PR flytekit#1557
I've verified that all the |
Fixed by flyteorg/flytekit#2483. |
Describe the issue
A few aliases defined in
numpy
were deprecated in v1.20.0 and finally removed inv1.24.0
(check Deprecations in https://github.com/numpy/numpy/releases/tag/v1.20.0).We should remove the mentions to those deprecated aliases from the FlyteSchemaTransformer.
What if we do not do this?
Users who install
numpy>=1.24.0
will see this error in flytekit:Related component(s)
flytekit
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: