Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Overwrite cached outputs flag doesn't work for reference launchplans #3550

Closed
2 tasks done
yubofredwang opened this issue Mar 29, 2023 · 1 comment · Fixed by flyteorg/flytepropeller#557
Closed
2 tasks done
Assignees
Labels
bug Something isn't working
Milestone

Comments

@yubofredwang
Copy link
Contributor

yubofredwang commented Mar 29, 2023

Describe the bug

When I trigger a workflow with overwrite cached outputs flag, the reference launchplans does not respect that flag. The tasks in the reference workflow still read cache from previous executions.

Expected behavior

When overwrite cached outputs flag is enabled, the reference launchplans that triggered as sub-workflows should also overwrite the cache.

If this is by design to have reference workflow to not respect the workflow, we should at least provide another flag/config to allow user to overwrite cache.

Additional context to reproduce

Create a workflow with reference workflow, enable caching on tasks and run with the overwrite cached outputs flag enabled.

Code Example:
File1

@task(
   cache=True,
   cache_version="1.0.0",
)
def fds_importer_parameter_serialization(a: str) -> str:
       return "hello" + a

@workflow
def fds_importer(a: str):
    fds_importer_parameter_serialization(a)

File2

@reference_launch_plan
def fds_importer(a: str):
    ...

@workflow
def my_workflow(a: str):
    fds_importer(a)

Screenshots

Screenshot 2023-03-28 at 5 28 08 PM

Screenshot 2023-03-28 at 5 28 15 PM

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@yubofredwang yubofredwang added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Mar 29, 2023
@wild-endeavor
Copy link
Contributor

@wild-endeavor and @hamersaw will look at this.

@yubofredwang yubofredwang changed the title [BUG] Overwrite cached outputs flag doesn't work for reference workflows [BUG] Overwrite cached outputs flag doesn't work for reference launchplans Apr 5, 2023
@eapolinario eapolinario removed the untriaged This issues has not yet been looked at by the Maintainers label Apr 7, 2023
@hamersaw hamersaw self-assigned this Apr 18, 2023
@hamersaw hamersaw added this to the 1.6.0 milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants