Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Maintaining Interruptible and OverwriteCache for reference launchplans #557

Merged
merged 3 commits into from
Apr 20, 2023

Conversation

hamersaw
Copy link
Contributor

TL;DR

The Interruptible and OverwriteCache flags should be maintained through the ExecutionSpec when running reference launchplans in from a workflow.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

fixes flyteorg/flyte#3550

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #557 (eb6f262) into master (972c0d6) will increase coverage by 0.43%.
The diff coverage is 62.50%.

❗ Current head eb6f262 differs from pull request most recent head 6e08cb7. Consider uploading reports for the commit 6e08cb7 to get more accurate results

Signed-off-by: Daniel Rammer <[email protected]>
@hamersaw hamersaw marked this pull request as ready for review April 18, 2023 16:11
@hamersaw hamersaw merged commit dd49c9d into master Apr 20, 2023
@hamersaw hamersaw deleted the bug/reference-launchplan-params branch April 20, 2023 20:20
eapolinario pushed a commit to eapolinario/flytepropeller that referenced this pull request Aug 9, 2023
flyteorg#557)

* maintaining Interruptible and OverwriteCache for reference launchplans

Signed-off-by: Daniel Rammer <[email protected]>

* fixed lint issues

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Overwrite cached outputs flag doesn't work for reference launchplans
2 participants