Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Single task execution should use promises in node inputs #370

Closed
3 of 20 tasks
katrogan opened this issue Jun 26, 2020 · 0 comments
Closed
3 of 20 tasks

[BUG] Single task execution should use promises in node inputs #370

katrogan opened this issue Jun 26, 2020 · 0 comments
Assignees
@katrogan
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Milestone
0.5.0

Comments

@katrogan
Copy link
Contributor

Describe the bug
Currently single task execution generates a workflow by looking at the task interface inputs and generating bindings from those. However those bindings should always be promises, rather than static values because they must directly come from the workflow inputs themselves.

Expected behavior
Single task executions should define nodes with inputs typed as promises

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Steps to reproduce the behavior:

  1. ...
  2. ...

Screenshots

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other

Additional context
@katrogan katrogan added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Jun 26, 2020
@katrogan katrogan self-assigned this Jun 26, 2020
@katrogan katrogan mentioned this issue Jun 26, 2020
Merged
8 tasks
@kumare3 kumare3 added this to the 0.5.0 milestone Jun 28, 2020
@kumare3 kumare3 closed this as completed Jun 30, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@kennyworkman
Kenny/type metadata (flyteorg#370)
7e8bc5f 
* feat: strip annotation from node template

Signed-off-by: Kenny Workman <[email protected]>

* feat: strip annotation tests

Signed-off-by: Kenny Workman <[email protected]>

* fix: strip outputs + test

Signed-off-by: Kenny Workman <[email protected]>

* fix: temp flyteidl for tests

Signed-off-by: Kenny Workman <[email protected]>

* fix: tmp update flyteidl

Signed-off-by: Kenny Workman <[email protected]>

* fix: range nil ok

Signed-off-by: Kenny Workman <[email protected]>

* fix: strip annotation in type compare

Signed-off-by: Kenny Workman <[email protected]>

* fix: rm .swp

Signed-off-by: Kenny Workman <[email protected]>

* fix: new flyteidl

Signed-off-by: Kenny Workman <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@kumare3
[wip] Refactors Flyteadmin to make every command, externally invokable (
f8556cd 
flyteorg#370)

* SQLite support

Signed-off-by: Ketan Umare <[email protected]>

* Move migrate commands

Signed-off-by: Ketan Umare <[email protected]>

* Clusterresource controller refactor

Signed-off-by: Ketan Umare <[email protected]>

* lint fix

Signed-off-by: Ketan Umare <[email protected]>

* test fix

Signed-off-by: Ketan Umare <[email protected]>

* updated

Signed-off-by: Ketan Umare <[email protected]>

* Updated to handle additional servers

Signed-off-by: Ketan Umare <[email protected]>

* lint fix

Signed-off-by: Ketan Umare <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@yindia
fix example task (flyteorg#370)
dd092c8 
* fix example task

Signed-off-by: Yuvraj <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@eugenejahn
fix: add more descriptive errors on task/workflow run failure (flyteo…
4e501fa 
…rg#370)

Signed-off-by: eugenejahn <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@flyte-bot
chore(release): Release 0.51.0 [skip ci]
6a277e0 
# [0.51.0](http://github.com/lyft/flyteconsole/compare/v0.50.4...v0.51.0) (2022-04-12)

### Bug Fixes

* add more descriptive errors on task/workflow run failure ([flyteorg#370](http://github.com/lyft/flyteconsole/issues/370)) ([4e501fa](http://github.com/lyft/flyteconsole/commit/4e501faae1fd46faba268d2803c7c5452fcc3c60))

### Features

* Allow to archive workflow from flyteconsole ([flyteorg#361](http://github.com/lyft/flyteconsole/issues/361)) ([1ed28c4](http://github.com/lyft/flyteconsole/commit/1ed28c4d566def6f286e164744c8da7e68f8d898))
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@wild-endeavor
New Demo image (flyteorg#370)
b523c54 
# TL;DR
This will let flytectl demo use the new bundled sandbox image instead.  See the issue for additional information.

`flytectl demo start`
* Brings up the new container
* kubeconfig will now be published to `~/.flyte/state/kubeconfig` (but the context will still be copied to the user's main kubeconfig with "flyte-sandbox" as the context name).

`flytectl demo reload`
Kills the Flyte pod, allowing the new one to come up.

Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@hamersaw
Add ImagePullBackoffGracePeriod configuration (flyteorg#370)
3d2525a 
* added ImagePullBackoffGracePeriod configuration

Signed-off-by: Daniel Rammer <[email protected]>

* fixed unit tests

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@kennyworkman
Kenny/type metadata (flyteorg#370)
77b265a 
* feat: strip annotation from node template

Signed-off-by: Kenny Workman <[email protected]>

* feat: strip annotation tests

Signed-off-by: Kenny Workman <[email protected]>

* fix: strip outputs + test

Signed-off-by: Kenny Workman <[email protected]>

* fix: temp flyteidl for tests

Signed-off-by: Kenny Workman <[email protected]>

* fix: tmp update flyteidl

Signed-off-by: Kenny Workman <[email protected]>

* fix: range nil ok

Signed-off-by: Kenny Workman <[email protected]>

* fix: strip annotation in type compare

Signed-off-by: Kenny Workman <[email protected]>

* fix: rm .swp

Signed-off-by: Kenny Workman <[email protected]>

* fix: new flyteidl

Signed-off-by: Kenny Workman <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@kumare3
[wip] Refactors Flyteadmin to make every command, externally invokable (
76af9b2 
flyteorg#370)

* SQLite support

Signed-off-by: Ketan Umare <[email protected]>

* Move migrate commands

Signed-off-by: Ketan Umare <[email protected]>

* Clusterresource controller refactor

Signed-off-by: Ketan Umare <[email protected]>

* lint fix

Signed-off-by: Ketan Umare <[email protected]>

* test fix

Signed-off-by: Ketan Umare <[email protected]>

* updated

Signed-off-by: Ketan Umare <[email protected]>

* Updated to handle additional servers

Signed-off-by: Ketan Umare <[email protected]>

* lint fix

Signed-off-by: Ketan Umare <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@hamersaw
Add ImagePullBackoffGracePeriod configuration (flyteorg#370)
dbd9da7 
* added ImagePullBackoffGracePeriod configuration

Signed-off-by: Daniel Rammer <[email protected]>

* fixed unit tests

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@wild-endeavor
New Demo image (flyteorg#370)
ebe66f2 
# TL;DR
This will let flytectl demo use the new bundled sandbox image instead.  See the issue for additional information.

`flytectl demo start`
* Brings up the new container
* kubeconfig will now be published to `~/.flyte/state/kubeconfig` (but the context will still be copied to the user's main kubeconfig with "flyte-sandbox" as the context name).

`flytectl demo reload`
Kills the Flyte pod, allowing the new one to come up.

Signed-off-by: Yee Hing Tong <[email protected]>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@wild-endeavor @austin362667
New Demo image (flyteorg#370)
173dc04 
# TL;DR
This will let flytectl demo use the new bundled sandbox image instead.  See the issue for additional information.

`flytectl demo start`
* Brings up the new container
* kubeconfig will now be published to `~/.flyte/state/kubeconfig` (but the context will still be copied to the user's main kubeconfig with "flyte-sandbox" as the context name).

`flytectl demo reload`
Kills the Flyte pod, allowing the new one to come up.

Signed-off-by: Yee Hing Tong <[email protected]>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@wild-endeavor @robert-ulbrich-mercedes-benz
New Demo image (flyteorg#370)
4099837 
# TL;DR
This will let flytectl demo use the new bundled sandbox image instead.  See the issue for additional information.

`flytectl demo start`
* Brings up the new container
* kubeconfig will now be published to `~/.flyte/state/kubeconfig` (but the context will still be copied to the user's main kubeconfig with "flyte-sandbox" as the context name).

`flytectl demo reload`
Kills the Flyte pod, allowing the new one to come up.

Signed-off-by: Yee Hing Tong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katrogan katrogan

Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
2 participants
@katrogan @kumare3