Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Ensure execution proto message values are utf-8 compliant #3729

Closed
2 tasks done
katrogan opened this issue May 26, 2023 · 0 comments · Fixed by flyteorg/flyteadmin#569
Closed
2 tasks done

[BUG] Ensure execution proto message values are utf-8 compliant #3729

katrogan opened this issue May 26, 2023 · 0 comments · Fixed by flyteorg/flyteadmin#569
Labels
bug Something isn't working flyteadmin Issue for FlyteAdmin Service untriaged This issues has not yet been looked at by the Maintainers
Milestone

Comments

@katrogan
Copy link
Contributor

katrogan commented May 26, 2023

Describe the bug

The console fails to render executions with Request failed with status code 500 grpc: error while marshaling: string field contains invalid UTF-8 when an execution proto message contains invalid utf-8 chars

This ultimately came down to loading node_executions failed
api/v1/node_executions/flytetester/development/awh8z9wmnc5hlp687vdn?filters=&limit=2&sort_by.direction=ASCENDING&sort_by.key=created_at

We should ensure that proto messages are serializable over grpc and that the console doesn't hard fail loading executions in the project overview

Expected behavior

Invalid execution names shouldn't be accepted

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@katrogan katrogan added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers flyteadmin Issue for FlyteAdmin Service labels May 26, 2023
@katrogan katrogan changed the title [BUG] Ensure user-provided execution names are utf-8 compliant [BUG] Ensure execution proto message values are utf-8 compliant May 26, 2023
@wild-endeavor wild-endeavor added this to the 1.7.0 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flyteadmin Issue for FlyteAdmin Service untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants