This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fix utf-8 encoding issues with trimmed error messages #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <[email protected]>
katrogan
changed the title
Codecov Report
@@ Coverage Diff @@
## master #569 +/- ##
==========================================
+ Coverage 58.63% 60.17% +1.54%
==========================================
Files 168 168
Lines 16251 13299 -2952
==========================================
- Hits 9528 8003 -1525
+ Misses 5881 4454 -1427
Partials 842 842
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
katrogan
changed the title
katrogan
requested review from
wild-endeavor,
EngHabu,
kumare3,
pmahindrakar-oss,
hamersaw and
eapolinario
as code owners
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
wild-endeavor
previously approved these changes
May 30, 2023
hamersaw
previously approved these changes
May 30, 2023
Signed-off-by: Katrina Rogan <[email protected]>
wild-endeavor
previously approved these changes
May 30, 2023
Signed-off-by: Katrina Rogan <[email protected]>
wild-endeavor
approved these changes
May 30, 2023
hamersaw
approved these changes
May 30, 2023
EngHabu
reviewed
May 31, 2023
|
For sure. We're going to have a patch release tomorrow morning. |
|
Flyte 1.6.2 is out and contains this fix. |
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Trimmed error messages returned in the list executions view are not always valid utf-8 strings. This changes ensures we trim error messages at valid utf-8 char boundaries
Type
Are all requirements met?
Complete description
Verified on an internal flyte deployment
Tracking Issue
fixes flyteorg/flyte#3729
Follow-up issue
NA