Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Custom environment variable injection does not work for complex workflow setup #3770

Closed
2 tasks done
honnix opened this issue Jun 12, 2023 · 0 comments · Fixed by flyteorg/flytepropeller#576
Closed
2 tasks done
Assignees
Labels
bug Something isn't working
Milestone

Comments

@honnix
Copy link
Member

honnix commented Jun 12, 2023

Describe the bug

A highly appreciated feature enabling injecting custom environment variable was added to flyte 1.6.0 release, for example the related change in flyteadmin: flyteorg/flyteadmin#556

We tested this feature on one of our workflows, and it partially worked.

For a simple container task, this worked well and we could observed the custom environment variables were injected into the container. For a complex task, in our case a remote launch plan (for a workflow with multiple tasks) backed task, the custom environment variables were not injected into containers that were part of the remote launch plan.

Expected behavior

Custom environment variables should be injected to all containers launched for a workflow execution, regardless how the workflow is composed.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@honnix honnix added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Jun 12, 2023
@hamersaw hamersaw removed the untriaged This issues has not yet been looked at by the Maintainers label Jun 12, 2023
@hamersaw hamersaw self-assigned this Jun 12, 2023
@hamersaw hamersaw added this to the 1.7.0 milestone Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants