Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add environment variables to execution spec #556

Merged
merged 9 commits into from
May 12, 2023
Merged

Add environment variables to execution spec #556

merged 9 commits into from
May 12, 2023

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented May 5, 2023

TL;DR

blocked by flyteorg/flyteidl#400
Add environment variables to execution spec, allowing people to add env at execution time

  • Create execution with environment variables
  • Override environment variables when relaunching
  • Override environment variables when recovering

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

flyteorg/flyte#2447

Follow-up issue

NA

pingsutw added 3 commits May 4, 2023 19:57
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #556 (9259cac) into master (507ad44) will increase coverage by 1.54%.
The diff coverage is 75.00%.

❗ Current head 9259cac differs from pull request most recent head 4b738f8. Consider uploading reports for the commit 4b738f8 to get more accurate results

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
+ Coverage   58.39%   59.94%   +1.54%     
==========================================
  Files         168      168              
  Lines       16093    13179    -2914     
==========================================
- Hits         9398     7900    -1498     
+ Misses       5858     4441    -1417     
- Partials      837      838       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/manager/impl/util/shared.go 68.52% <33.33%> (+3.01%) ⬆️
pkg/workflowengine/impl/prepare_execution.go 86.66% <100.00%> (+1.66%) ⬆️

... and 153 files with indirect coverage changes

hamersaw
hamersaw previously approved these changes May 8, 2023
@pingsutw
Copy link
Member Author

pingsutw commented May 8, 2023

blocked by IDL pr flyteorg/flyteidl#400

Signed-off-by: Kevin Su <[email protected]>
pingsutw added 4 commits May 9, 2023 15:32
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw marked this pull request as draft May 10, 2023 10:07
@pingsutw pingsutw marked this pull request as ready for review May 10, 2023 10:10
@pingsutw pingsutw merged commit 2fdd399 into master May 12, 2023
@pingsutw pingsutw deleted the env branch May 12, 2023 17:55
LaPetiteSouris pushed a commit to LaPetiteSouris/flyteadmin that referenced this pull request May 16, 2023
* Add envs to execution spec

Signed-off-by: Kevin Su <[email protected]>

* update

Signed-off-by: Kevin Su <[email protected]>

* update

Signed-off-by: Kevin Su <[email protected]>

* fix tests

Signed-off-by: Kevin Su <[email protected]>

* update idl

Signed-off-by: Kevin Su <[email protected]>

* lint

Signed-off-by: Kevin Su <[email protected]>

* fix tests

Signed-off-by: Kevin Su <[email protected]>

* fix tests

Signed-off-by: Kevin Su <[email protected]>

---------

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: TungHoang <[email protected]>
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
* Add envs to execution spec

Signed-off-by: Kevin Su <[email protected]>

* update

Signed-off-by: Kevin Su <[email protected]>

* update

Signed-off-by: Kevin Su <[email protected]>

* fix tests

Signed-off-by: Kevin Su <[email protected]>

* update idl

Signed-off-by: Kevin Su <[email protected]>

* lint

Signed-off-by: Kevin Su <[email protected]>

* fix tests

Signed-off-by: Kevin Su <[email protected]>

* fix tests

Signed-off-by: Kevin Su <[email protected]>

---------

Signed-off-by: Kevin Su <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants