This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Add environment variables to execution spec #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw
requested review from
katrogan,
wild-endeavor,
EngHabu,
kumare3,
pmahindrakar-oss,
hamersaw and
eapolinario
as code owners
May 5, 2023 08:21
Signed-off-by: Kevin Su <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
==========================================
+ Coverage 58.39% 59.94% +1.54%
==========================================
Files 168 168
Lines 16093 13179 -2914
==========================================
- Hits 9398 7900 -1498
+ Misses 5858 4441 -1417
- Partials 837 838 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hamersaw
previously approved these changes
May 8, 2023
blocked by IDL pr flyteorg/flyteidl#400 |
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
hamersaw
approved these changes
May 11, 2023
LaPetiteSouris
pushed a commit
to LaPetiteSouris/flyteadmin
that referenced
this pull request
May 16, 2023
* Add envs to execution spec Signed-off-by: Kevin Su <[email protected]> * update Signed-off-by: Kevin Su <[email protected]> * update Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> * update idl Signed-off-by: Kevin Su <[email protected]> * lint Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]> Signed-off-by: TungHoang <[email protected]>
2 tasks
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Add envs to execution spec Signed-off-by: Kevin Su <[email protected]> * update Signed-off-by: Kevin Su <[email protected]> * update Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> * update idl Signed-off-by: Kevin Su <[email protected]> * lint Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
blocked by flyteorg/flyteidl#400
Add environment variables to execution spec, allowing people to add env at execution time
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
flyteorg/flyte#2447
Follow-up issue
NA