-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic support for Blob input type in Launch form #378
Comments
schottra
added
enhancement
New feature or request
ui
Admin console user interface
labels
Jul 7, 2020
This is perfect and IMO fits 90% of the use-cases |
@schottra I added it to 0.6.0 :) |
Implemented by flyteorg/flyteconsole#86 |
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 6, 2022
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 6, 2022
* Added execution config changes Signed-off-by: Prafulla Mahindrakar <[email protected]> * lint fixes Signed-off-by: Prafulla Mahindrakar <[email protected]> * using executionConfig data during launch Signed-off-by: Prafulla Mahindrakar <[email protected]> * resolve conflicts Signed-off-by: Prafulla Mahindrakar <[email protected]> * Removed defaults for labels and annotations Signed-off-by: Prafulla Mahindrakar <[email protected]> * added more coverage Signed-off-by: Prafulla Mahindrakar <[email protected]> * added more coverage Signed-off-by: Prafulla Mahindrakar <[email protected]> * Updating idl and lint fixes Signed-off-by: Prafulla Mahindrakar <[email protected]> * Adde missing go.sum Signed-off-by: Prafulla Mahindrakar <[email protected]> * feedback changes to return immediately if any field is set while overriding Signed-off-by: Prafulla Mahindrakar <[email protected]> * using released flyteidl Signed-off-by: Prafulla Mahindrakar <[email protected]> * using released flyteidl Signed-off-by: Prafulla Mahindrakar <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 20, 2022
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Jul 24, 2023
…rg#378) Previously, the hash set on an input literal would be ignored if the literal was of either the `Collection` or `Map` type. This is fixed here by moving the hash-checking branch up in front of the special type logic, so that an empty literal with hash is constructed in either case if a hash is found. Adds a regression test to verify the hashes are carried over into the representer literals for both map and collection types. Signed-off-by: Nicholas Junge <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Aug 9, 2023
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Aug 21, 2023
* Added execution config changes Signed-off-by: Prafulla Mahindrakar <[email protected]> * lint fixes Signed-off-by: Prafulla Mahindrakar <[email protected]> * using executionConfig data during launch Signed-off-by: Prafulla Mahindrakar <[email protected]> * resolve conflicts Signed-off-by: Prafulla Mahindrakar <[email protected]> * Removed defaults for labels and annotations Signed-off-by: Prafulla Mahindrakar <[email protected]> * added more coverage Signed-off-by: Prafulla Mahindrakar <[email protected]> * added more coverage Signed-off-by: Prafulla Mahindrakar <[email protected]> * Updating idl and lint fixes Signed-off-by: Prafulla Mahindrakar <[email protected]> * Adde missing go.sum Signed-off-by: Prafulla Mahindrakar <[email protected]> * feedback changes to return immediately if any field is set while overriding Signed-off-by: Prafulla Mahindrakar <[email protected]> * using released flyteidl Signed-off-by: Prafulla Mahindrakar <[email protected]> * using released flyteidl Signed-off-by: Prafulla Mahindrakar <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Aug 21, 2023
…rg#378) Previously, the hash set on an input literal would be ignored if the literal was of either the `Collection` or `Map` type. This is fixed here by moving the hash-checking branch up in front of the special type logic, so that an empty literal with hash is constructed in either case if a hash is found. Adds a regression test to verify the hashes are carried over into the representer literals for both map and collection types. Signed-off-by: Nicholas Junge <[email protected]>
eapolinario
pushed a commit
that referenced
this issue
Sep 8, 2023
* Add backend plugin system service Signed-off-by: Kevin Su <[email protected]> * Add backend plugin system service Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * update state Signed-off-by: Kevin Su <[email protected]> * update state Signed-off-by: Kevin Su <[email protected]> * dics Signed-off-by: Kevin Su <[email protected]> * Remove output prefix from get request Signed-off-by: Kevin Su <[email protected]> * update Signed-off-by: Kevin Su <[email protected]> * remove prev state Signed-off-by: Kevin Su <[email protected]> * update proto Signed-off-by: Kevin Su <[email protected]> * remove error message Signed-off-by: Kevin Su <[email protected]> * update comment Signed-off-by: Kevin Su <[email protected]> * make generate Signed-off-by: Kevin Su <[email protected]> * Rename the service Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]>
eapolinario
pushed a commit
that referenced
this issue
Sep 13, 2023
* Add backend plugin system service Signed-off-by: Kevin Su <[email protected]> * Add backend plugin system service Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * update state Signed-off-by: Kevin Su <[email protected]> * update state Signed-off-by: Kevin Su <[email protected]> * dics Signed-off-by: Kevin Su <[email protected]> * Remove output prefix from get request Signed-off-by: Kevin Su <[email protected]> * update Signed-off-by: Kevin Su <[email protected]> * remove prev state Signed-off-by: Kevin Su <[email protected]> * update proto Signed-off-by: Kevin Su <[email protected]> * remove error message Signed-off-by: Kevin Su <[email protected]> * update comment Signed-off-by: Kevin Su <[email protected]> * make generate Signed-off-by: Kevin Su <[email protected]> * Rename the service Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]>
pvditt
pushed a commit
that referenced
this issue
Dec 29, 2023
* Add backend plugin system service Signed-off-by: Kevin Su <[email protected]> * Add backend plugin system service Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * update state Signed-off-by: Kevin Su <[email protected]> * update state Signed-off-by: Kevin Su <[email protected]> * dics Signed-off-by: Kevin Su <[email protected]> * Remove output prefix from get request Signed-off-by: Kevin Su <[email protected]> * update Signed-off-by: Kevin Su <[email protected]> * remove prev state Signed-off-by: Kevin Su <[email protected]> * update proto Signed-off-by: Kevin Su <[email protected]> * remove error message Signed-off-by: Kevin Su <[email protected]> * update comment Signed-off-by: Kevin Su <[email protected]> * make generate Signed-off-by: Kevin Su <[email protected]> * Rename the service Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to #22 but being split out as a separate high-impact quick win.
Full support for Blobs will likely involve uploading files to a storage location and receiving back the
uri
where they are stored.But a very workable basic solution could be achieved by having the user specify a
uri
(string),format
(string), and selecting one of two values fordimensionality
(single or multipart). A grouping of 3 simple inputs would allow a user to specify these values when launching.Validation would only check that the string inputs have values in them. We won't validate the semantics of the values.
The text was updated successfully, but these errors were encountered: