Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] console feature flags loading out of order #3896

Closed
2 tasks done
FrankFlitton opened this issue Jul 26, 2023 · 0 comments · Fixed by flyteorg/flyteconsole#804
Closed
2 tasks done

[BUG] console feature flags loading out of order #3896

FrankFlitton opened this issue Jul 26, 2023 · 0 comments · Fixed by flyteorg/flyteconsole#804
Assignees
@FrankFlitton
Labels
bug Something isn't working navigation Improving the user experience when navigating from one section of the docs to another ui Admin console user interface

Comments

@FrankFlitton
Copy link

Describe the bug

The existing logic loaded the defaults twice. The current order is defaults, env, defaults, url params. This leads to unexpected behavior.

Expected behavior

The flags should load in this order: defaults, env, url params.

Additional context to reproduce

Env doesn't overide default setting.

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@FrankFlitton FrankFlitton added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers and removed untriaged This issues has not yet been looked at by the Maintainers labels Jul 26, 2023
@FrankFlitton FrankFlitton self-assigned this Jul 26, 2023
@FrankFlitton FrankFlitton added ui Admin console user interface navigation Improving the user experience when navigating from one section of the docs to another labels Jul 26, 2023
@FrankFlitton FrankFlitton mentioned this issue Jul 26, 2023
Merged
8 tasks
@FrankFlitton FrankFlitton changed the title [BUG] Console feature flags loading out of order [BUG] console feature flags loading out of order Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrankFlitton FrankFlitton

Labels
bug Something isn't working navigation Improving the user experience when navigating from one section of the docs to another ui Admin console user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: breadcrumb feature flag priority order flyteorg/flyteconsole
1 participant
@FrankFlitton