Fix: breadcrumb feature flag priority order #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
ursucarina
approved these changes
Jul 26, 2023
jsonporter
approved these changes
Jul 26, 2023
|
🎉 This PR is included in version 1.9.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Change the feature flag logic priority order.
Old: default, env, default, params,
New: default, env, params
Now:
default: falseenv: truewill enable a flagdefault: falseenv: trueparams: falsewill disable a flagType
Are all requirements met?
Complete description
Tested by adding the breadcrumb env var to
yarn startscript to verify loading order.Tracking Issue
fixes flyteorg/flyte#3896
Follow-up issue
NA