[FlyteCtl] Get LaunchPlan #393
Assignees
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
Milestone
Comments
brucearctor
added
enhancement
kumare3
added
good first issue
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 6, 2022
* A new metrics scope per plugin is created Signed-off-by: Ketan Umare <[email protected]> * updated setup context Signed-off-by: Ketan Umare <[email protected]> * added unit test Signed-off-by: Ketan Umare <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 6, 2022
* Require Content MD5 for SignedURL Signed-off-by: Haytham Abuelfutuh <[email protected]> * Send MD5 as []byte Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update deps Signed-off-by: Haytham Abuelfutuh <[email protected]> * fix unit test Signed-off-by: Haytham Abuelfutuh <[email protected]> * Revert local config change Signed-off-by: Haytham Abuelfutuh <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Aug 9, 2023
* A new metrics scope per plugin is created Signed-off-by: Ketan Umare <[email protected]> * updated setup context Signed-off-by: Ketan Umare <[email protected]> * added unit test Signed-off-by: Ketan Umare <[email protected]>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Aug 21, 2023
* Require Content MD5 for SignedURL Signed-off-by: Haytham Abuelfutuh <[email protected]> * Send MD5 as []byte Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update deps Signed-off-by: Haytham Abuelfutuh <[email protected]> * fix unit test Signed-off-by: Haytham Abuelfutuh <[email protected]> * Revert local config change Signed-off-by: Haytham Abuelfutuh <[email protected]>
eapolinario
pushed a commit
that referenced
this issue
Sep 6, 2023
* Fix the Input Error Signed-off-by: Future Outlier <[email protected]> * submitting a databricks job Signed-off-by: Future Outlier <[email protected]> --------- Signed-off-by: Future Outlier <[email protected]> Co-authored-by: Future Outlier <[email protected]>
eapolinario
added a commit
that referenced
this issue
Sep 8, 2023
* Move to official remote plugins Signed-off-by: eduardo apolinario <[email protected]> * Regenerate python files Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: eduardo apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
eapolinario
added a commit
that referenced
this issue
Sep 13, 2023
* Move to official remote plugins Signed-off-by: eduardo apolinario <[email protected]> * Regenerate python files Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: eduardo apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]>
pvditt
pushed a commit
that referenced
this issue
Dec 29, 2023
* Move to official remote plugins Signed-off-by: eduardo apolinario <[email protected]> * Regenerate python files Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: eduardo apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
hamersaw
pushed a commit
that referenced
this issue
Dec 18, 2024
This change adds a new `FastTaskAssignment` message type to fast task protos, which is used to send actor assignment info to admin via task events.
While here I also hardened linting on our protos and updates existing protos to conform. This matches the restrictions we have in place in unionai/cloud/idl
- [x] Add and run unittests
- [x] Run locally and verify worker assignment info comes through in task events
```
❯ curl -s http://localhost:8088/api/v1/task_executions/flytesnacks/development/f0dcb5e7cae6d47acaf3/n0\?limit\=100 | jq '.taskExecutions[0].closure.metadata.externalResources'
[
{
"externalId": "",
"index": 0,
"retryAttempt": 0,
"phase": "UNDEFINED",
"cacheStatus": "CACHE_DISABLED",
"logs": [],
"customInfo": {
"assignedWorker": "example-2b377271ee80",
"environmentId": "flytesnacks_development_example_c183cb6c9868d96"
}
}
]
❯ curl -s http://localhost:8088/api/v1/task_executions/flytesnacks/development/f0dcb5e7cae6d47acaf3/n1\?limit\=100 | jq '.taskExecutions[0].closure.metadata.externalResources'
[
{
"externalId": "",
"index": 0,
"retryAttempt": 0,
"phase": "UNDEFINED",
"cacheStatus": "CACHE_DISABLED",
"logs": [],
"customInfo": {
"assignedWorker": "example-2b377271ee80",
"environmentId": "flytesnacks_development_example_c183cb6c9868d96"
}
}
]
```
One merged, bring to cloud. Will be a no-op initially, but we can use this in a few dependent tasks to surface logs or look up other fast task worker info.
Should this change be upstreamed to OSS (flyteorg/flyte)? If not, please uncheck this box, which is used for auditing. Note, it is the responsibility of each developer to actually upstream their changes. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F).
- [ ] To be upstreamed to OSS
ref COR-1581
Add custom info field to ExternalResourceInfo
Adds a custom info field to `ExternalResourceInfo`. This is an extension of the [ExternalId](https://github.com/unionai/flyte/blob/2b6dfcaedab7ed6a7606d1434211086d064c6560/flyteidl/protos/flyteidl/event/event.proto#L269) field and can be used to pass plugin specific context or identifiers. We will use this to pass fast task worker assignment.
N/A
Just merge, not used yet
Should this change be upstreamed to OSS (flyteorg/flyte)? If not, please uncheck this box, which is used for auditing. Note, it is the responsibility of each developer to actually upstream their changes. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F).
- [x] To be upstreamed to OSS
ref COR-1581
Closes #393
hamersaw
pushed a commit
that referenced
this issue
Dec 18, 2024
This change adds a new `FastTaskAssignment` message type to fast task protos, which is used to send actor assignment info to admin via task events.
While here I also hardened linting on our protos and updates existing protos to conform. This matches the restrictions we have in place in unionai/cloud/idl
- [x] Add and run unittests
- [x] Run locally and verify worker assignment info comes through in task events
```
❯ curl -s http://localhost:8088/api/v1/task_executions/flytesnacks/development/f0dcb5e7cae6d47acaf3/n0\?limit\=100 | jq '.taskExecutions[0].closure.metadata.externalResources'
[
{
"externalId": "",
"index": 0,
"retryAttempt": 0,
"phase": "UNDEFINED",
"cacheStatus": "CACHE_DISABLED",
"logs": [],
"customInfo": {
"assignedWorker": "example-2b377271ee80",
"environmentId": "flytesnacks_development_example_c183cb6c9868d96"
}
}
]
❯ curl -s http://localhost:8088/api/v1/task_executions/flytesnacks/development/f0dcb5e7cae6d47acaf3/n1\?limit\=100 | jq '.taskExecutions[0].closure.metadata.externalResources'
[
{
"externalId": "",
"index": 0,
"retryAttempt": 0,
"phase": "UNDEFINED",
"cacheStatus": "CACHE_DISABLED",
"logs": [],
"customInfo": {
"assignedWorker": "example-2b377271ee80",
"environmentId": "flytesnacks_development_example_c183cb6c9868d96"
}
}
]
```
One merged, bring to cloud. Will be a no-op initially, but we can use this in a few dependent tasks to surface logs or look up other fast task worker info.
Should this change be upstreamed to OSS (flyteorg/flyte)? If not, please uncheck this box, which is used for auditing. Note, it is the responsibility of each developer to actually upstream their changes. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F).
- [ ] To be upstreamed to OSS
ref COR-1581
Add custom info field to ExternalResourceInfo
Adds a custom info field to `ExternalResourceInfo`. This is an extension of the [ExternalId](https://github.com/unionai/flyte/blob/2b6dfcaedab7ed6a7606d1434211086d064c6560/flyteidl/protos/flyteidl/event/event.proto#L269) field and can be used to pass plugin specific context or identifiers. We will use this to pass fast task worker assignment.
N/A
Just merge, not used yet
Should this change be upstreamed to OSS (flyteorg/flyte)? If not, please uncheck this box, which is used for auditing. Note, it is the responsibility of each developer to actually upstream their changes. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F).
- [x] To be upstreamed to OSS
ref COR-1581
Closes #393
Signed-off-by: Daniel Rammer <[email protected]>
hamersaw
added a commit
that referenced
this issue
Dec 18, 2024
* Send actor worker assignment in task events (#394)(#393) This change adds a new `FastTaskAssignment` message type to fast task protos, which is used to send actor assignment info to admin via task events. While here I also hardened linting on our protos and updates existing protos to conform. This matches the restrictions we have in place in unionai/cloud/idl - [x] Add and run unittests - [x] Run locally and verify worker assignment info comes through in task events ``` ❯ curl -s http://localhost:8088/api/v1/task_executions/flytesnacks/development/f0dcb5e7cae6d47acaf3/n0\?limit\=100 | jq '.taskExecutions[0].closure.metadata.externalResources' [ { "externalId": "", "index": 0, "retryAttempt": 0, "phase": "UNDEFINED", "cacheStatus": "CACHE_DISABLED", "logs": [], "customInfo": { "assignedWorker": "example-2b377271ee80", "environmentId": "flytesnacks_development_example_c183cb6c9868d96" } } ] ❯ curl -s http://localhost:8088/api/v1/task_executions/flytesnacks/development/f0dcb5e7cae6d47acaf3/n1\?limit\=100 | jq '.taskExecutions[0].closure.metadata.externalResources' [ { "externalId": "", "index": 0, "retryAttempt": 0, "phase": "UNDEFINED", "cacheStatus": "CACHE_DISABLED", "logs": [], "customInfo": { "assignedWorker": "example-2b377271ee80", "environmentId": "flytesnacks_development_example_c183cb6c9868d96" } } ] ``` One merged, bring to cloud. Will be a no-op initially, but we can use this in a few dependent tasks to surface logs or look up other fast task worker info. Should this change be upstreamed to OSS (flyteorg/flyte)? If not, please uncheck this box, which is used for auditing. Note, it is the responsibility of each developer to actually upstream their changes. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F). - [ ] To be upstreamed to OSS ref COR-1581 Add custom info field to ExternalResourceInfo Adds a custom info field to `ExternalResourceInfo`. This is an extension of the [ExternalId](https://github.com/unionai/flyte/blob/2b6dfcaedab7ed6a7606d1434211086d064c6560/flyteidl/protos/flyteidl/event/event.proto#L269) field and can be used to pass plugin specific context or identifiers. We will use this to pass fast task worker assignment. N/A Just merge, not used yet Should this change be upstreamed to OSS (flyteorg/flyte)? If not, please uncheck this box, which is used for auditing. Note, it is the responsibility of each developer to actually upstream their changes. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F). - [x] To be upstreamed to OSS ref COR-1581 Closes #393 Signed-off-by: Daniel Rammer <[email protected]> * removed unused time import Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]> Co-authored-by: Andrew Dye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: