Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FlyteCtl] Get MatchableEntity #400

Closed
brucearctor opened this issue Jul 9, 2020 · 1 comment
Closed

[FlyteCtl] Get MatchableEntity #400

brucearctor opened this issue Jul 9, 2020 · 1 comment
Labels
enhancement New feature or request flytectl Issues related to flytectl -Flytes CLI good first issue Good for newcomers

Comments

@brucearctor
Copy link
Contributor

No description provided.

@brucearctor brucearctor added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Jul 9, 2020
@kumare3 kumare3 added good first issue Good for newcomers help wanted Extra attention is needed and removed untriaged This issues has not yet been looked at by the Maintainers labels Jul 9, 2020
@kumare3 kumare3 added flytectl Issues related to flytectl -Flytes CLI and removed help wanted Extra attention is needed labels Feb 9, 2021
@yindia yindia assigned yindia and unassigned yindia Apr 2, 2021
@pmahindrakar-oss
Copy link
Contributor

Taken care of using this #992

eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@EngHabu
Implement GetGeneratedNameWith (flyteorg#400)
ac6f5be 
* Implement GetGeneratedNameWith

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update plugins version

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Unit test

Signed-off-by: Haytham Abuelfutuh <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@katrogan
Store resolved security context in execution spec model (flyteorg#400)
a936f65 
Signed-off-by: Katrina Rogan <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@olga-union
feat: add cache icons for cached tasks in graph view (flyteorg#400)
0c0cd4b 
* feat: add cache icons for cached tasks in graph view

Signed-off-by: Olga Nad <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@flyte-bot
chore(release): Release 0.54.0 [skip ci]
2995f3c 
# [0.54.0](http://github.com/lyft/flyteconsole/compare/v0.53.0...v0.54.0) (2022-04-18)

### Features

* add cache icons for cached tasks in graph view ([flyteorg#400](http://github.com/lyft/flyteconsole/issues/400)) ([0c0cd4b](http://github.com/lyft/flyteconsole/commit/0c0cd4b21d621afd1465be9efbb9b21a807d5e00))
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@EngHabu
Implement GetGeneratedNameWith (flyteorg#400)
6016844 
* Implement GetGeneratedNameWith

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update plugins version

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Unit test

Signed-off-by: Haytham Abuelfutuh <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@katrogan
Store resolved security context in execution spec model (flyteorg#400)
a7f65ea 
Signed-off-by: Katrina Rogan <[email protected]>
eapolinario pushed a commit that referenced this issue Sep 8, 2023
@pingsutw
Add envs to execution spec (#400)
f68015b 
Signed-off-by: Kevin Su <[email protected]>
eapolinario pushed a commit that referenced this issue Sep 13, 2023
@pingsutw @eapolinario
Add envs to execution spec (#400)
2b35eff 
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario pushed a commit that referenced this issue Sep 26, 2023
@hamersaw
Fix resources requests for AWS Batch plugin (#400)
dc0b719 
* retrieving resources from container before merging with overrides and defaults

Signed-off-by: Daniel Rammer <[email protected]>

* fixed linter

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
pvditt pushed a commit that referenced this issue Dec 29, 2023
@pingsutw
Add envs to execution spec (#400)
d9e760d 
Signed-off-by: Kevin Su <[email protected]>
iaroslav-ciupin added a commit that referenced this issue Sep 26, 2024
@iaroslav-ciupin
Don't send inputURI for start-node (#400)
95c91dd 
* send empty `inputUri` for `start-node` in node execution event to flyteadmin and therefore, GetNodeExecutionData will not attempt to download non-existing inputUri as it was doing before this change.
* add DB migration to clear `input_uri` in existing `node_executions` table for start nodes.

*TODO: Summarize tests added, integration tests run, or other steps you took to validate this change. Include (or link to) relevant test output or screenshots.*

*TODO: Describe any deployment or compatibility considerations for rolling out this change.*

Should this change be upstreamed to OSS (flyteorg/flyte)? If not, please uncheck this box, which is used for auditing. Note, it is the responsibility of each developer to actually upstream their changes. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F).
- [x] To be upstreamed to OSS

* fixes COR-1134 by sending empty `inputUri` in node execution event to flyteadmin and therefore, `GetNodeExecutionData` will not attempt to download non-existing `inputUri` as it was doing before this change.

* [ ] Added tests
* [ ] Ran a deploy dry run and shared the terraform plan
* [ ] Added logging and metrics
* [ ] Updated [dashboards](https://unionai.grafana.net/dashboards) and [alerts](https://unionai.grafana.net/alerting/list)
* [ ] Updated documentation
iaroslav-ciupin added a commit that referenced this issue Sep 27, 2024
@iaroslav-ciupin
Don't send inputURI for start-node (#400)
a0ba30b 
* send empty `inputUri` for `start-node` in node execution event to flyteadmin and therefore, GetNodeExecutionData will not attempt to download non-existing inputUri as it was doing before this change.
* add DB migration to clear `input_uri` in existing `node_executions` table for start nodes.

*TODO: Summarize tests added, integration tests run, or other steps you took to validate this change. Include (or link to) relevant test output or screenshots.*

*TODO: Describe any deployment or compatibility considerations for rolling out this change.*

Should this change be upstreamed to OSS (flyteorg/flyte)? If not, please uncheck this box, which is used for auditing. Note, it is the responsibility of each developer to actually upstream their changes. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F).
- [x] To be upstreamed to OSS

* fixes COR-1134 by sending empty `inputUri` in node execution event to flyteadmin and therefore, `GetNodeExecutionData` will not attempt to download non-existing `inputUri` as it was doing before this change.

* [ ] Added tests
* [ ] Ran a deploy dry run and shared the terraform plan
* [ ] Added logging and metrics
* [ ] Updated [dashboards](https://unionai.grafana.net/dashboards) and [alerts](https://unionai.grafana.net/alerting/list)
* [ ] Updated documentation

Signed-off-by: Iaroslav Ciupin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request flytectl Issues related to flytectl -Flytes CLI good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brucearctor @yindia @kumare3 @pmahindrakar-oss